-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Phone 8.1 Support #173
Conversation
Thanks for the addition @nigel-sampson. TC build breaks on this change with a few errors around missing types. Will have to check this out later. |
That's weird, built correctly on my machine and am using it in a project. Will look as well. |
This turns out to be due to lack of .Net 4.5.1 on TC. Will have to install that and then will take this in. I wonder if this will impact contributors with the same setup as TC! |
I installed it and it wasn't .Net 4.5.1. Must be WP8.1 SDK then. |
Of course, yeah, I'm and idiot. I imagine the PCL profiles wouldn't be installed without Visual Studio Update 2 RC. |
I am a bit unsure about this addition then. On the one hand it's awesome to have it there for the users of the library and I want it in there too. On the other hand it might become a pain for contributors who don't have WP8.1 SDK. Hmmmm! |
So these days there is no separate WP8.1 SDK but it's built into the Visual Studio Update 2 RC. Admittedly the update is still RC so it may make sense to wait to release? |
Oh, didn't know. Thanks. I really like this addition; but I think we should wait for the release to reduce the impact on other contributors. |
Update 2 has eventually reached RTM status (plus they released an early and bugged CTP of Update 3). |
Thanks. I will check it out. I will need to install it on TeamCity too; otherwise it will break the build! |
FYI - working on a project with @GregoryJames this week with a Win8.1 app and this support would have been handy. We worked around having it so all good but just wanted to add a +1 :) |
Any new son this? I am working on a Windows Phone 8.1 XAML project where I can really use Humanizer. |
I haven't had a chance to do it tbh. Will most likely do it this weekend though. |
Rebased and pushed this up. |
This is now available on NuGet as v1.28.0. Thanks for the contribution and sorry about the delay. |
Added support to the Portable library for Windows Phone 8.1 and modified nuget package.