Add feminine gender for french ordinal words #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feminine gender for french ordinal words + test
|
"première" (first) is the only ordinal word genderized in french. |
| @@ -107,5 +107,13 @@ public void ToOrdinalWords(int number, string words) | |||
| { | |||
| Assert.Equal(words, number.ToOrdinalWords()); | |||
| } | |||
|
|
|||
| [Theory] | |||
| [InlineData(1, "première", GrammaticalGender.Feminine)] | |||
There was a problem hiding this comment.
I think we need a few more test cases: a test with 2 showing that only 1 causes the gender to take effect and a couple of tests with other numbers showing they're not impacted with gender.
|
Please add the tests and add your PR to release notes. Rebase if needed. Thanks. |
|
Done |
MehdiK
added a commit
that referenced
this pull request
Apr 13, 2014
Add feminine gender for french ordinal words
|
This is now on NuGet as v1.22.1. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feminine gender for french ordinal words + test