Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovenian localisation #244

Closed
wants to merge 6 commits into from

Conversation

MitjaBezensek
Copy link
Contributor

No description provided.


[Theory]
[InlineData(-10, "pred 10 leti")]
[InlineData(-5, "pred 5 leti")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, for years 5 is the same as 3 and 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slovenian is quite a strange language. For years ago 3,4,5,... are the same. For years from now 3 and 4 are the same and everything from 5 on is the same.

This difference for numbers 3 and 4 occurs only when counting. We don't have actual trial or quadral grammatical numbers (we do have dual tho). I implemented this by using a different postfix for dual and one combined one for 3 and 4. Which is why some test seems duplicate since in some cases 3 and 4 are the same a 5. Those tests check if the resource files does indeed have the (duplicate) value for number 3 and 4.

Well testing for 10 could probably be omitted, since it's always the same as for 5.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, cool. Thanks for explaining. Just wanted to make sure :)

MehdiK pushed a commit that referenced this pull request Apr 26, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 26, 2014

Thanks. This is merged now.

@MehdiK MehdiK closed this Apr 26, 2014
@MitjaBezensek MitjaBezensek deleted the slovenian branch April 26, 2014 14:09
@MehdiK
Copy link
Member

MehdiK commented Apr 27, 2014

This is now available on NuGet as v1.25.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants