Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add German localisation for ToOrdinalWords and Ordinalize #257

Merged
merged 4 commits into from May 3, 2014

Conversation

mexx
Copy link
Collaborator

@mexx mexx commented May 1, 2014

No description provided.

public OrdinalizeTests() : base("de-DE") { }

[Theory]
[InlineData("0", "0.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a strange rule!

@MehdiK MehdiK merged commit 1361cba into Humanizr:master May 3, 2014
@MehdiK
Copy link
Member

MehdiK commented May 21, 2014

This is now released to NuGet as v1.26.1. Thanks for the addition.

@hazzik
Copy link
Member

hazzik commented May 21, 2014

BTW, @MehdiK, I always wanted to ask, why version is x.yy.1 when you bump minor (yy)?

@MehdiK
Copy link
Member

MehdiK commented May 21, 2014

Not always. The last release was 1.25.4 for example; but it's true to a
great extent. It's because we don't do many patches and bug fixes. It's
almost always additions and in semver an addition bumps the minor.

On Tue, May 20, 2014 at 11:21 PM, Alexander Zaytsev <
notifications@github.com> wrote:

BTW, @MehdiK https://github.com/MehdiK, I always wanted to ask, why
version always is x.yy.1?


Reply to this email directly or view it on GitHubhttps://github.com//pull/257#issuecomment-43708533
.

@mexx
Copy link
Collaborator Author

mexx commented May 21, 2014

I think the question was why not x.yy.0 when you bump the minor :)

@hazzik
Copy link
Member

hazzik commented May 21, 2014

@mexx got it right.

@MehdiK
Copy link
Member

MehdiK commented May 21, 2014

It's a good question and the answer is the power of defaults. TeamCity
resets the build number to 1 and that's what's been used for version number.

On Wed, May 21, 2014 at 9:00 AM, Alexander Zaytsev <notifications@github.com

wrote:

@mexx https://github.com/mexx got it right.


Reply to this email directly or view it on GitHubhttps://github.com//pull/257#issuecomment-43750710
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants