-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added byte rate calculation functons, closes #296 #314
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ec1b931
Added byte rate calculation functons, closes #296
GeorgeHahn 75bc12b
Tweak byte rate API; finishes implementation for issue #296
GeorgeHahn a797f97
Addressing issues raised in CR
GeorgeHahn 20147cd
Pull changes from upstream, fix merge conflict in release notes
GeorgeHahn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
using System; | ||
using Humanizer.Bytes; | ||
using Xunit; | ||
using Xunit.Extensions; | ||
|
||
namespace Humanizer.Tests.Bytes | ||
{ | ||
public class ByteRateTests : AmbientCulture | ||
{ | ||
public ByteRateTests() : base("en") { } | ||
|
||
[Theory] | ||
[InlineData(400, 1, "400 B/s")] | ||
[InlineData(4 * 1024, 1, "4 KB/s")] | ||
[InlineData(4 * 1024 * 1024, 1, "4 MB/s")] | ||
[InlineData(4 * 2 * 1024 * 1024, 2, "4 MB/s")] | ||
[InlineData(4 * 1024, 0.1, "40 KB/s")] | ||
[InlineData(15 * 60 * 1024 * 1024, 60, "15 MB/s")] | ||
public void HumanizesRates(long inputBytes, double perSeconds, string expectedValue) | ||
{ | ||
var size = new ByteSize(inputBytes); | ||
var interval = TimeSpan.FromSeconds(perSeconds); | ||
|
||
var rate = size.Per(interval).ToRatePerSecond(); | ||
|
||
Assert.Equal(expectedValue, rate); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Text; | ||
|
||
namespace Humanizer.Bytes | ||
{ | ||
public class ByteRate | ||
{ | ||
public ByteSize size { get; private set;} | ||
|
||
public TimeSpan interval { get; private set; } | ||
|
||
public ByteRate(ByteSize size, TimeSpan interval) | ||
{ | ||
this.size = size; | ||
this.interval = interval; | ||
} | ||
|
||
/// <summary> | ||
/// Return this rate as a string, EG "2 MB/s" | ||
/// </summary> | ||
/// <returns></returns> | ||
public string ToRatePerSecond() | ||
{ | ||
return (new ByteSize(size.Bytes / interval.TotalSeconds)).Humanize() + "/s"; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the property names to CamelCase.