fix time span humanization precision skipping

[mexx]

fixes #339

[MehdiK]

What do you think about the suggestions at #339 (comment)?

[MehdiK]

I am not so sure about the optional param. It's not clear why one would want to use that and it could actually be used without passing the precision, timespan.Humanize(considerEmptyParts: true), which is not good.

I'd suggest adding the following three methods:

public static string Humanize(this TimeSpan timeSpan, CultureInfo culture = null)
public static string Humanize(this TimeSpan timeSpan, int precision, bool ignoreEmptyUnits = false, CultureInfo culture = null)
[Deprecated]
public static string Humanize(this TimeSpan timeSpan, int precision, CultureInfo culture = null)

A couple of things to highlight:

• precision on the overload is not optional anymore
• considerEmptyParts has been renamed to ignoreEmptyUnits but the default value is left as false. This means that the logic should change to by default not ignore empty units which will keep the change backward compatible for those who hadn't passed the culture in. Due to the name change the implementation needs to be reversed too.

[MehdiK]

Thanks for the change @mexx. I left a comment on the method signature. What do you think?

Also please add the addition to the readme file.

[mexx]

I've changed the implementation and made the parameters in the overload mandatory,
as it correctly don't make sense to call it without precision.
I also renamed the parameter to countEmptyUnits, for me it better transports the meaning.
For example:

TimeSpan.FromMilliseconds(3603001).Humanize(3, countEmptyUnits:true)

With ignoreEmptyUnits it should be

TimeSpan.FromMilliseconds(3603001).Humanize(3, ignoreEmptyUnits:false)

as by default of current behavior empty units would be ignored.

@MehdiK What do you think?

[MehdiK]

I like it. Thanks.