Use RegexOptions.Compiled if available #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ public static class RomanNumeralExtensions | |||
| private static readonly Regex ValidRomanNumeral = | |||
| new Regex( | |||
| "^(?i:(?=[MDCLXVI])((M{0,3})((C[DM])|(D?C{0,3}))?((X[LC])|(L?XX{0,2})|L)?((I[VX])|(V?(II{0,2}))|V)?))$", | |||
| RegexOptions.None); | |||
| RegexOptions.None | RegexOptionsUtil.Compiled); | |||
There was a problem hiding this comment.
Could RegexOptions.None be simply replaced by RegexOptionsUtil.Compiled?
hazzik
force-pushed
the
regex-compiled
branch
from
29c4d88
to
935bef4
Compare
|
Thanks @hazzik. Can you please add this to release notes? |
|
done |
|
Merged. Thanks. |
hazzik
force-pushed
the
regex-compiled
branch
from
708778b
to
002cb06
Compare
|
I'm not quite sure what happened on reopen and merge here but the commit graph still looks intact!! |
|
I forced branch tip update so Github recognizes that this has been merged |
|
This is now released to NuGet. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.