Added culture specific decimal separator #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a culture specific decimal separator in the TryParse method of ByteSize.cs to provide correct parsing on systems where the decimal separator is other than ".".
|
This PR has broken the build. Please fix the build and add your PR to the release notes file. Nice fix BTW. |
|
I fixed the build and added the PR to the release-notes file. Thanks. |
|
This is now released to NuGet as v1.35.0. Thanks for the contribution. |
|
Thank you for merging, sorry for late reply and apologizes for the trouble with the broken build. Cheers and keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a culture specific decimal separator in the TryParse method of ByteSize.cs to provide correct parsing on systems where the decimal separator is other than ".".