collection formatter generalized to "OxfordStyle" and "RegularStyle" #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2015 16:18
…(regarding the concatenation and 'comma before and), registry uses for 'de' and 'it' the regular style, for 'en' still the oxford style.
|
Actually this is a good change after close look. Sorry about that |
|
@ThomasMentzel please add this PR to release notes according to CONTRIBUTING.md with message like "added German collection formatter". |
…h, Portuguese and Norwegian
|
I added the required information. I added additional languages according to wikipedia and google translator . |
|
Very nice addition. Thanks. This is now rebased and pushed. |
|
This is now released to NuGet as v1.34.0. Thanks. |
|
DefaultDeparator ?? |
|
Sorry @Bartmax - not sure what you mean! Can you please elaborate a bit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is regarding the concatenation of multiple items with comma and e.g. "and". See:
new []{"Peter", "Paul", "Mary"} => EN => "Peter, Paul, and Mary" (if you use Oxford style)
new []{"Peter", "Paul", "Mary"} => EN => "Peter, Paul and Mary" (if you dont use Oxford style)
new []{"Peter", "Paul", "Mary"} => DE => "Peter, Paul and Mary" (this is how it works in italian and german)
The English and Italian version got generaltized to "OxfordSyle" and "RegularStyle". The registry now uses these base classes with a constructor parameter to get the default separator.
The registry now registers a german collection formatter.