Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Croatian TimeSpan localization bug #598

Merged
merged 1 commit into from
Dec 2, 2016

Commits on Dec 1, 2016

  1. Squashed commit of the following:

    commit f9423de
    Author: hangy <hangy@hangy.de>
    Date:   Thu Dec 1 20:48:01 2016 +0100
    
        Update TimeSpanHumanizeTests.cs
    
    commit 2e5dfe5
    Author: hangy <hangy@hangy.de>
    Date:   Thu Dec 1 20:37:50 2016 +0100
    
        Apparently I'm stupid and 7 days actually get humanized as 1 week.
    
    commit 152a119
    Author: hangy <hangy@hangy.de>
    Date:   Wed Nov 30 23:50:51 2016 +0100
    
        Workaround for unneeded suffix: Just use the same value.
    
        The reason for this workaround is that at the method that decides if the suffix should be applied, the information about the time unit is not available. So it would either need to do some string magic and explicitly exclude the "TimeSpanHumanize_MultipleDays" resource key from adding the postfix, or most of the `TimeSpan` formatting code would need to be rewriten for Croatian or modified for all languages to support Croatian. Neither seems reasonable for a quick change.
    
    commit 002cc7b
    Author: hangy <hangy@hangy.de>
    Date:   Wed Nov 30 23:12:57 2016 +0100
    
        Added some more tests. From what I've read, all days should resolve to "dana" for the Croatian language. (No "_DualTrialQuadral" postfix.")
    
    commit c190e9d
    Author: hangy <hangy@hangy.de>
    Date:   Tue Nov 22 00:29:51 2016 +0100
    
        Add initial test for issue 597.
    hangy committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    4d6a015 View commit details
    Browse the repository at this point in the history