Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the precompiling directives #127

Merged
merged 4 commits into from
Mar 13, 2022
Merged

Changed the precompiling directives #127

merged 4 commits into from
Mar 13, 2022

Conversation

FrankUrbach
Copy link
Collaborator

Changing the precompiling directives was necessary for 1.7.2 compatibility reasons.
All tests are green for this.

@FrankUrbach FrankUrbach added the bug Something isn't working label Mar 2, 2022
@FrankUrbach FrankUrbach self-assigned this Mar 2, 2022
@FrankUrbach FrankUrbach added this to In progress in TypeDBClient V1 via automation Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #127 (a238cec) into main (ff10951) will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   25.05%   25.58%   +0.53%     
==========================================
  Files          50       50              
  Lines        7951     7644     -307     
==========================================
- Hits         1992     1956      -36     
+ Misses       5959     5688     -271     
Impacted Files Coverage Δ
src/precompile/precompile_ProtoBuf.jl 0.00% <ø> (ø)
src/core/CoreSession.jl 0.00% <0.00%> (ø)
src/logic/Explanation.jl 0.00% <0.00%> (ø)
src/stream/ResponseCollector.jl 0.00% <0.00%> (ø)
src/stream/RequestTransmitter.jl 0.00% <0.00%> (ø)
src/stream/BidirectionalStream.jl 0.00% <0.00%> (ø)
src/generated/session_pb.jl 23.30% <0.00%> (+0.15%) ⬆️
src/standard/utils.jl 11.42% <0.00%> (+0.31%) ⬆️
src/generated/core_database_pb.jl 30.23% <0.00%> (+0.32%) ⬆️
src/generated/answer_pb.jl 18.15% <0.00%> (+0.38%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff10951...a238cec. Read the comment docs.

TypeDBClient V1 automation moved this from In progress to Reviewer approved Mar 13, 2022
Copy link
Member

@tk3369 tk3369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankUrbach FrankUrbach merged commit 349aec4 into main Mar 13, 2022
@FrankUrbach FrankUrbach deleted the compat-1.7.2-change branch March 13, 2022 11:01
TypeDBClient V1 automation moved this from Reviewer approved to Done Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants