Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest dev into main #36

Merged
merged 80 commits into from
Mar 5, 2021
Merged

Merge latest dev into main #36

merged 80 commits into from
Mar 5, 2021

Conversation

mkschulze
Copy link
Member

No description provided.

= and others added 30 commits January 17, 2021 15:32
corresponding jl file. Added Protobuf to Project.toml
Added setup script for protocol generation
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #36 (c20ffa5) into main (9bfb8c8) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main     #36    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         10      20    +10     
  Lines       5488    5694   +206     
======================================
- Misses      5488    5694   +206     
Impacted Files Coverage Δ
src/GraknOptions.jl 0.00% <0.00%> (ø)
src/client.jl 0.00% <0.00%> (ø)
src/common/exception.jl 0.00% <0.00%> (ø)
src/concept/ConceptManager.jl 0.00% <0.00%> (ø)
src/generated/answer_pb.jl 0.00% <ø> (ø)
src/generated/cluster/cluster_pb.jl 0.00% <ø> (ø)
src/generated/cluster/database_pb.jl 0.00% <ø> (ø)
src/generated/concept_pb.jl 0.00% <ø> (ø)
src/generated/database_pb.jl 0.00% <ø> (ø)
src/generated/grakn_pb.jl 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfb8c8...ececda1. Read the comment docs.

Copy link
Collaborator

@FrankUrbach FrankUrbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit is only to get the things in one place from where all feature branches can be made. Be aware there is many python code for reading the systematic. If a feature is fully implemented the python code should be deleted.

@FrankUrbach FrankUrbach requested review from Azzaare and FrankUrbach and removed request for Azzaare March 5, 2021 20:52
@mkschulze mkschulze merged commit 2795fdf into main Mar 5, 2021
@mkschulze mkschulze deleted the dev branch March 5, 2021 21:04
@mkschulze mkschulze added the enhancement New feature or request label Mar 15, 2021
@mkschulze mkschulze added this to In progress in TypeDBClient V1 via automation Mar 15, 2021
@mkschulze mkschulze added this to the Version 1.0 milestone Mar 15, 2021
@FrankUrbach FrankUrbach moved this from In progress to Done in TypeDBClient V1 Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants