Implement RequestBuilder, Thing & Type concepts #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkschulze
requested changes
Apr 11, 2021
mkschulze
approved these changes
Apr 11, 2021
| Return value will be a subtype of `AbstractType`. | ||
| """ | ||
| function instantiate(t::Proto._Type) | ||
| label = hasproperty(t, :scope) ? Label(t.scope, t.label) : Label(t.label) |
There was a problem hiding this comment.
It's :scope, a symbol. That's how you test if a property exists in an object. Unlike a normal Julia struct fields, a ProtoBuf codegen object will report the existence of a property only after you set a value for that property. So an empty object would not have any property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's better to merge to main branch before the snowball rolls too big... so I'm submitting this PR.
Current status
I added Pretend.jl as a dependency. It's a mocking framework from me :-) The reason is that I want to create unit tests without having to test against a real server. An example can be found at
test/unit/test_concepts.jl.