New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lossy Tolerance #7

Open

cesutherland opened this issue Feb 20, 2012 · 1 comment

Member

cesutherland commented Feb 20, 2012

When diffing PNGs or other lossy items the API provides a tolerance parameter. Sometimes canvas is lossy when we don't expect it to be. Writing / reading imagedata with an alpha layer is lossy (see http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation).

Can we encapsulate this away from the user?
Or can our matchers intelligently suggest this is the issue when a test has failed?

Contributor

jsantell commented Feb 20, 2012

Explore canvas' CanvasRenderingContext2d#patternQuality method, changing from good to best
https://github.com/LearnBoost/node-canvas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment