Fix dynamic :focused? by tracking in text-input's *state #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix HumbleUI#50 (Using text-input in ui/dynamic makes it unfocusable) Initial commit has known issue where parent focusables are still bugged and do not receive focus.
|
No, let’s not do that. I don’t want to keep duplicate of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50 (Using text-input in ui/dynamic makes it unfocusable)
Seems a little clunky, especially because the wrapping
defn text-fieldnow has an additional deref against the *stateInitial commit has known issue where parent
on-key-focusis bugged and do not receive focus, even when the child text-input receives focus. This means they can't trigger any key-events. I'm assuming this means there's a better fix for focus somewhere deeper in the library?