Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Theme #161

Open
1 of 3 tasks
tonsky opened this issue Oct 4, 2021 · 4 comments
Open
1 of 3 tasks

Implement Theme #161

tonsky opened this issue Oct 4, 2021 · 4 comments
Labels
Good First Issue Good for newcomers Platform: macOS Platform: Windows

Comments

@tonsky
Copy link
Collaborator

tonsky commented Oct 4, 2021 •
edited
Loading

Inspired by https://www.electronjs.org/docs/api/native-theme

Theme::isHighContrast
Theme::isDark
Theme::isInverted

  • Windows
  • X11
  • macOS
tonsky added a commit that referenced this issue Oct 4, 2021
@tonsky
Theme for macOS, PanelTheme #153 #161
5a680f3
tonsky added a commit that referenced this issue Oct 4, 2021
@tonsky
Theme for macOS, PanelTheme #153 #161
5c9782c
tonsky added a commit that referenced this issue Oct 4, 2021
@tonsky
Theme for macOS, PanelTheme #153 #161
b4a6c73
tonsky added a commit that referenced this issue Oct 4, 2021
@tonsky
Theme for macOS, PanelTheme #153 #161
bada613
@i10416 i10416 mentioned this issue Oct 4, 2021
Merged
@Alex2772
Copy link
Collaborator

Alex2772 commented Oct 5, 2021

Why there's not Linux? At least you can determine light/dark theme by quering GTK theme name. Every GTK theme mentions whether it's dark or not in it's name.

@tonsky
Copy link
Collaborator Author

tonsky commented Oct 6, 2021

Right, dark/light seems to be possible on Linux, I missed that

@DevSrSouza
Copy link

There is now an official system theme for dark/light preference in Linux being adopted by couple Desktop Environments

Resources:

@tonsky
Copy link
Collaborator Author

tonsky commented Feb 14, 2022

Thank you! That will help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for newcomers Platform: macOS Platform: Windows
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tonsky @Alex2772 @DevSrSouza