Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bug/class weight matching #205

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

HunterMcGushion
Copy link
Owner

@HunterMcGushion HunterMcGushion commented Oct 27, 2019

  • Fix bug matching Experiment Descriptions including hyperparameter types not handled by JSON
  • Accomplish above by switching to YAML Descriptions
  • Can revert back to JSON Descriptions via settings.G.description_format

- Originally, only .json files were considered
- Now, three extensions are checked: ".yaml", ".yml", and ".json" (in that order)
- Add `ruamel.yaml` to dependencies
- Fix bug in `read_yaml` because `yml.load` expected a
  `pathlib.Path` instance, rather than a string
- Minor refactoring, and moved utility definitions to put
  general utilities at top (most importantly, `RetryMakeDirs`)
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #205 into master will decrease coverage by 0.06%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   94.61%   94.55%   -0.07%     
==========================================
  Files          46       46              
  Lines        4956     4973      +17     
==========================================
+ Hits         4689     4702      +13     
- Misses        267      271       +4
Impacted Files Coverage Δ
hyperparameter_hunter/i_o/exceptions.py 87.23% <ø> (-0.77%) ⬇️
...yperparameter_hunter/optimization/protocol_core.py 98% <100%> (ø) ⬆️
hyperparameter_hunter/settings.py 93.75% <100%> (+0.2%) ⬆️
hyperparameter_hunter/utils/optimization_utils.py 90.47% <75%> (-4.77%) ⬇️
hyperparameter_hunter/i_o/recorders.py 87.01% <85%> (-2.09%) ⬇️
hyperparameter_hunter/i_o/result_reader.py 95.54% <90.9%> (-0.03%) ⬇️
hyperparameter_hunter/utils/file_utils.py 92% <96.87%> (+2.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96200fe...44bd1be. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 29, 2019

Pull Request Test Coverage Report for Build 887

  • 102 of 111 (91.89%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 94.551%

Changes Missing Coverage Covered Lines Changed/Added Lines %
hyperparameter_hunter/i_o/result_reader.py 10 11 90.91%
hyperparameter_hunter/utils/file_utils.py 62 64 96.88%
hyperparameter_hunter/i_o/recorders.py 17 20 85.0%
hyperparameter_hunter/utils/optimization_utils.py 9 12 75.0%
Totals Coverage Status
Change from base Build 879: -0.06%
Covered Lines: 4702
Relevant Lines: 4973

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants