Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/predict proba index #95

Merged
merged 4 commits into from
Nov 11, 2018
Merged

Conversation

HunterMcGushion
Copy link
Owner

  • Closes logloss issue... #90, opened by @caprone
  • The do_predict_proba parameter of environment.Environment (and consequently models.Model) is now allowed to be an int, as well as a bool
    • If do_predict_proba is an int, the predict_proba method is called, and the int specifies the index of the column in the model's probability predictions whose values should be passed on as the final predictions
    • Original behavior when passing a boolean is unaffected
    • See Environment documentation for usage notes and warnings about providing truthy or falsey values for the do_predict_proba parameter

… a boolean

This allows one to specify a particular column from a model's probability predictions to pass
forward as the final predictions. If `do_predict_proba` is an int, then the `predict` method of
`models.Model` will call `predict_proba` on the inner model to return probability predictions,
and the integer identifies the index of the column whose values should be used as predictions.
Original behavior when providing boolean values for `do_predict_proba` remains unchanged.
…, and add note referencing Environment documentation
@HunterMcGushion HunterMcGushion mentioned this pull request Nov 9, 2018
@HunterMcGushion HunterMcGushion merged commit 9204f29 into master Nov 11, 2018
@HunterMcGushion HunterMcGushion deleted the feat/predict-proba-index branch November 11, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant