fix: use default value when 'ErrorEvent.error' not exists (#27)

* fix: 在资源路径不存在下error为undefined的情况 * feat: 调整默认信息文案
HuolalaTech · Dec 20, 2023 · 6919682 · 6919682
1 parent 2813763
commit 6919682
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/src/plugins/error.ts b/src/plugins/error.ts
@@ -34,9 +34,16 @@ export default class ErrorPlugin implements PageSpyPlugin {
 
   private onUncaughtError() {
     const errorHandler = (e: ErrorEvent) => {
-      const { message, stack } = e.error;
-      const errorDetail = formatErrorObj(e.error);
-      ErrorPlugin.sendMessage(stack || message, errorDetail);
+      if (e.error) {
+        const { message, stack } = e.error;
+        const errorDetail = formatErrorObj(e.error);
+        ErrorPlugin.sendMessage(stack || message, errorDetail);
+      } else {
+        // When the error does not exist, use default information
+        const defaultMessage =
+          '[PageSpy] An unknown error occurred and no stack trace available';
+        ErrorPlugin.sendMessage(defaultMessage, null);
+      }
     };
     window.addEventListener('error', errorHandler);
   }

diff --git a/tests/plugins/error.test.ts b/tests/plugins/error.test.ts
@@ -16,4 +16,14 @@ describe('Error plugin', () => {
     window.dispatchEvent(new Event('unhandledrejection'));
     expect(errorOccupied).toHaveBeenCalledTimes(3);
   });
+
+  it('Should handle error event without error object', () => {
+    window.dispatchEvent(new Event('error'));
+
+    expect(errorOccupied).toHaveBeenCalledTimes(3);
+    expect(errorOccupied).toHaveBeenCalledWith(
+      '[PageSpy] An unknown error occurred and no stack trace available',
+      null,
+    );
+  });
 });