Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using STL #61

Closed
bufalo1973 opened this issue Oct 26, 2023 · 3 comments
Closed

Using STL #61

bufalo1973 opened this issue Oct 26, 2023 · 3 comments
Assignees
@drfiemost
Labels
enhancement

Comments

@bufalo1973
Copy link

I've been taking a look at the code and I'm asking, why use the "C list" way instead of using STL containers? First example is in GegnerClass. I think it would make the code easier (and shorter?) to maintain using STL.
@drfiemost
Copy link
Member

The original code is quite old, there have been some efforts to modernize it but there is still room for improvement.

I think I gave a try at converting it into a std::list or something but didn't succeed for some reason and gave up.

drfiemost added a commit that referenced this issue Nov 1, 2023
@drfiemost
Use STL container for enemies list (#61)
8baf617
drfiemost added a commit that referenced this issue Nov 2, 2023
@drfiemost
Enemy list cleanup (#61)
7f390a5
@drfiemost drfiemost self-assigned this Nov 3, 2023
@drfiemost drfiemost mentioned this issue Nov 7, 2023
Merged
@drfiemost
Copy link
Member

The enemies are done, next steps are projectiles and particles.

@Mia75owo Mia75owo mentioned this issue Nov 20, 2023
Merged
@Mia75owo Mia75owo mentioned this issue Dec 3, 2023
Merged
@drfiemost
Copy link
Member

It seems we got rid of custom lists now. Thanks to @Nils75owo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drfiemost drfiemost

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drfiemost @bufalo1973