Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 逐字歌词使用 Win2D 实现 #418

Merged
merged 23 commits into from Jul 17, 2023
Merged

[feat] 逐字歌词使用 Win2D 实现 #418

merged 23 commits into from Jul 17, 2023

Conversation

kengwang
Copy link
Member

@kengwang kengwang commented Jul 8, 2023

No description provided.

@kengwang kengwang added · 增强 新功能新特性 ~近期完成 将会在近期进行修复 labels Jul 8, 2023
@kengwang kengwang self-assigned this Jul 8, 2023
@kengwang kengwang linked an issue Jul 8, 2023 that may be closed by this pull request
[WIP] 歌词使用 Win2D 绘制 #410
Closed
@kengwang kengwang marked this pull request as draft July 8, 2023 09:42
@kengwang
Copy link
Member Author

kengwang commented Jul 9, 2023

0001-feat-obsolete-Win2D-Composition.patch

使用 Win2D 套上 Composition 绘制歌词列表

@Clrs17
Merge branch 'develop' into feat/lyric-control
e566b14 
Signed-off-by: Claris <118241780+Clrs17@users.noreply.github.com>
@kengwang
Copy link
Member Author

@Clrs17 TNX, 这个分支没有那个歌单 Item 的异常修复, 每次调试都很烦. 但一直没把 develop merge 进来 /笑哭

@kengwang kengwang marked this pull request as ready for review July 16, 2023 04:37
@kengwang
Copy link
Member Author

我创建的 Pr，似乎不能自己给自己review

@Clrs17
Merge branch 'develop' into feat/lyric-control
477e7d9 
Signed-off-by: Claris <118241780+Clrs17@users.noreply.github.com>
@Clrs17 Clrs17 self-requested a review July 16, 2023 05:08
@Clrs17
Copy link
Contributor

Clrs17 commented Jul 16, 2023

我创建的 Pr，似乎不能自己给自己review

我merge了一下，你现在可以了
只是最后一个提交者不可以

zxbmmmmmmmmm
zxbmmmmmmmmm requested changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@zxbmmmmmmmmm zxbmmmmmmmmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有个问题，切歌的时候小窗歌词可能不会更新....

@kengwang kengwang merged commit 3995b30 into develop Jul 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxbmmmmmmmmm zxbmmmmmmmmm zxbmmmmmmmmm approved these changes

@Clrs17 Clrs17 Awaiting requested review from Clrs17

Assignees

@kengwang kengwang

@zxbmmmmmmmmm zxbmmmmmmmmm

Labels
~近期完成 将会在近期进行修复 · 增强 新功能新特性
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WIP] 歌词使用 Win2D 绘制
3 participants
@kengwang @Clrs17 @zxbmmmmmmmmm