How to document forbidden dereferencability #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sOf definitions that should fix imposed resource dereferencability
tpluscode
suggested changes
Jul 18, 2020
asbjornu
suggested changes
Jul 18, 2020
| "label": "Hydra Class", | ||
| "comment": "The class of Hydra classes. Hydra classes and their instances are dereferenceable resources.", | ||
| "comment": "The class of Hydra classes.", |
There was a problem hiding this comment.
Should we explain what "The class of Hydra classes" actually mean? If a hydra:Class is no longer dereferenceable, what good does it do?
There was a problem hiding this comment.
Id' leave it as is. Most of the hydra terms are rooted in hydra:Class - I believe it's enough to have it just to have those hydra terms separated.
If a hydra:Class is no longer dereferenceable,
We indeed removed this requirements as it is virtually impossible to enforce, but still I'd read something that is a hydra:Class SHOULD be dereferencable (I don't see any good reasons against it). Developers still have a possibility of not having those resource dereferencable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please find the modifications (removal of
hydra:Resource) of the severalrdfs:range,rdfs:domainandrdfs:subClassOfdefinitions that should fix imposed resource dereferencability .More details
This should address issue #216 as the core issue was that several places in hydra imposed fact that resources are dereferencable, which in many cases was untrue (not to mention the fact that having i.e. an HTTP based URL doesn't mean it can be freely dereferenced).
There are still a few places where
hydra:Resourceis left:hydra:Linkandhydra:TemplatedLinkare stillhydra:Resource. Removing it fromhydra:Linkcould break hydra:apiDocumentation as it actually should be dereferencable. Also links defined by API should connect callable resources.hydra:operationhas still domain ofhydra:Resource. Operations should be invokable on a callable resource.hydra:Collectionandhydra:PartialCollectionVieware still sub-classes ofhydra:Resource. These are API artificial wrappers over some resource sets and should be callable.hydra:first/hydra:last/hydra:next/hydra:prevhave stillhydra:Resourceas both their domains and ranges. Otherwise the described interlinked set of resources would cease to be, well, interlinked.hydra:searchandhydra:freetextQueryhave stillhydra:Resourceas it's domain. If a client came that far to have that link, it probably means that the resource is already callable.Feel free to participate in the review as this is a major modification that should improve hydra's applicability to other than RDF areas.