Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable representation of individual template mappings #245

Conversation

alien-mcl
Copy link
Member

Summary

Relaxed domain of variableRepresentation to cover both IriTemplate and IriTemplateMapping.

More details

This pull request addresses issue #244 by relaxing domain of the variableRepresentation predicate to IriTemplate and IriTemplateMapping.

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typos

spec/latest/core/index.html Outdated Show resolved Hide resolved
spec/latest/core/index.html Outdated Show resolved Hide resolved
spec/latest/core/core.jsonld Outdated Show resolved Hide resolved
spec/latest/core/index.html Outdated Show resolved Hide resolved
spec/latest/core/index.html Outdated Show resolved Hide resolved
spec/latest/core/index.html Outdated Show resolved Hide resolved
spec/latest/core/index.html Show resolved Hide resolved
spec/latest/core/index.html Outdated Show resolved Hide resolved
@tpluscode
Copy link
Contributor

Ping

@alien-mcl
Copy link
Member Author

I've applied your suggestions @tpluscode . Sorry for the delay!

Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two final tweaks and 👍 to this one

spec/latest/core/index.html Outdated Show resolved Hide resolved
spec/latest/core/index.html Outdated Show resolved Hide resolved
@tpluscode
Copy link
Contributor

@alien-mcl really close here. Would you mind having a look here so that we could merge?

@alien-mcl alien-mcl merged commit 80896b6 into HydraCG:master Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants