Output variable selection

[brycemihal]

Would be good to add a section where output variables can be turned on or off

[cbuahin]

@brycemihal so what I am thinking is we will have a default set of variables that will be written no matter what and the rest can be optional. Could you provide a list of those that you would like to be optional ? Is this something that should be implemented for other components as well ?

[brycemihal]

This is what I had in mind. I think that making some of these outputs (like time, flow, and temperature) always turned on would be okay. Otherwise variables are in a list and a YES or NO by them indicates whether to write them out. If a variable is not listed then it defaults to YES. The same for hts and rhe components. [OutputVariables] time YES element_junction_id NO x NO y NO z NO element_id NO from_junction NO to_junction NO element_x NO element_y NO length NO flow YES velocity NO depth NO width NO xsection_area NO dispersion NO temperature YES volume_time_derivative NO water_age NO total_element_heat_balance NO total_element_adv_disp_heat_balance NO total_element_evap_heat_balance NO total_element_conv_heat_balance NO total_element_radiation_flux_heat_balance NO total_element_external_heat_flux_balance NO total_element_solute_mass_balance NO total_element_adv_disp_solute_mass_balance NO total_element_external_solute_flux_mass_balance NO element_evap_heat_flux YES element_conv_heat_flux YES element_fluid_friction_heat_flux NO element_radiation_flux NO element_heat_flux NO element_air_temp NO element_relative_humidity NO element_wind_speed NO element_vapor_pressure NO element_saturated_vapor_pressure NO element_air_vapor_pressure NO element_air_saturated_vapor_pressure NO total_heat_balance NO total_adv_disp_heat_balance NO total_evap_heat_balance NO total_conv_heat_balance NO total_radiation_flux_heat_balance NO total_external_heat_flux_balance NO solute_names NO solute_concentration NO total_solute_mass_balance NO total_adv_disp_solute_mass_balance NO total_external_solute_flux_mass_balance NO

…

On Wed, Jul 31, 2019 at 11:13 AM Caleb Buahin ***@***.***> wrote: @brycemihal <https://github.com/brycemihal> so what I am thinking is we will have a default set of variables that will be written no matter what and the rest can be optional. Could you provide a list of those that you would like to be optional ? Is this something that should be implemented for other components as well ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=ACX5IHNGE3HOFMHUSRPICILQCHB3TA5CNFSM4IIIV5Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3H53QY#issuecomment-516939203>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACX5IHPB5L6RDZ7A7DGASWTQCHB3TANCNFSM4IIIV5ZQ> .

[brycemihal]

Also would be good to only write out data at a specified model cell. For example, temperature could look like:

temperature [L_1,L_50,L_200] for only 3 cells

or

temperature [L_1:L_200] for all cells between 1 and 200

[cbuahin]

@brycemihal, I think I will hold off implementing this additional feature at this time. I can see myself making a mistake running a whole simulation and forgetting to write some cells out. I think selecting the variables to turn off/on is a good start. My suspicion from doing some tests over the weekend is that doing this alone will save considerable space and time.

[brycemihal]

Thanks Caleb. Looking forward to trying it. With bigger/coupled models I could see having the ability to choose which model cells get written out being useful still. As you said though, I think this is a good start. Bryce

…

On Wed, Aug 7, 2019 at 8:27 AM Caleb Buahin ***@***.***> wrote: @brycemihal <https://github.com/brycemihal>, I think I will hold off implementing this additional feature at this time. I can see myself making a mistake running a whole simulation and forgetting to write some cells out. I think selecting the variables to turn off/on is a good start. My suspicion from doing some tests over the weekend is that doing this alone will save considerable space and time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=ACX5IHJNHNOVZRGP7M27373QDLLWVA5CNFSM4IIIV5Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3YSYGA#issuecomment-519121944>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACX5IHOFCMDKKKOIQWXUC6TQDLLWVANCNFSM4IIIV5ZQ> .

[cbuahin]

@brycemihal , I had added the feature you requested. You can download the new HydroCoupleComposer installer (https://github.com/HydroCouple/HydroCoupleComposer/releases/download/v1.4.0/HydroCoupleComposer.msi) and test it. All variables are defaulted to be written out unless you specify that they not be written. Variables that are written once at the beginning of a simulation cannot be turned off (e.g., x, y, z, length, solute_names, etc.) as they have very little influence on file size and io performance.

[brycemihal]

Caleb, I have tested this with the CSH and HTS component. I does work for the CSH but did not work for the HTS component. I did find one error in cshmodelio.cpp on line 946. You have "element_heat_flux" but it should be "element_air_temp". I made the change and pushed it to my branch, but I'm not sure my branch is up to date, so it's on a difference line number. Also, this doesn't seem to be implemented in the RHE component yet. Are you planning on adding it there too? Thanks

…

On Mon, Aug 12, 2019 at 12:08 AM Caleb Buahin ***@***.***> wrote: @brycemihal <https://github.com/brycemihal> , I had added the feature you requested. You can download the new HydroCoupleComposer installer ( https://github.com/HydroCouple/HydroCoupleComposer/releases/download/v1.4.0/HydroCoupleComposer.msi) and test it. All variables are defaulted to be written out unless you specify that it not be written. Variables that are written once at the beginning of a simulation cannot be turned off as they have very little influence on file size and io performance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=ACX5IHJ7U7UAPTUWD6IJ2NDQED46ZA5CNFSM4IIIV5Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BUHTA#issuecomment-520307660>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACX5IHIYIQKCRQRYNXAKBM3QED46ZANCNFSM4IIIV5ZQ> .

[cbuahin]

@brycemihal , I fixed the bug you found for the CSH and have made the variables optional for the HTS and RHE components. It should be available in the latest HydroCoupleComposer release. Let me know if you find any additional bugs.

[cbuahin]

@brycemihal , here are the commits. It seems the commit I screwed up somewhere for the RHE commit. I will check it out tonight.

• fb62083

• HydroCouple/HTSComponent@1db430d