Added HTML lang="en" (#2688)

* Added HTML lang="en" Primarily an accessibility concern for screen reader software. * Replace StringBuffer with StringBuilder StringBuilder was introduced in Java 5 and removes the synchronization in StringBuffer making it faster. * Revert StringBuilder use with Mockito Compilation error seen in https://travis-ci.com/Hygieia/Hygieia/builds/98910093
hygieia · Jan 29, 2019 · d199971 · d199971
1 parent eb226b3
commit d199971
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/api-audit/src/main/resources/static/swagger/index.html b/api-audit/src/main/resources/static/swagger/index.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
     <meta charset="UTF-8">
     <title>Swagger UI</title>

diff --git a/api/src/main/resources/static/swagger/index.html b/api/src/main/resources/static/swagger/index.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
     <meta charset="UTF-8">
     <title>Swagger UI</title>

diff --git a/api/src/test/java/com/capitalone/dashboard/logging/KeyValueLoggingFilterTest.java b/api/src/test/java/com/capitalone/dashboard/logging/KeyValueLoggingFilterTest.java
@@ -75,7 +75,7 @@ public void setup() {
 
         ReflectionTestUtils.setField(filter, "appName", appName);
         ReflectionTestUtils.setField(filter, "version", appVersion);
-        StringBuffer buffer = new StringBuffer();
+        StringBuffer buffer = new StringBuffer();// StringBuilder use caused problems with Mockito
         buffer.append(requestUrl);
         when(request.getRequestURL()).thenReturn(buffer);
         when(request.getRemoteAddr()).thenReturn(remoteAddress);

diff --git a/collectors/feature/jira/src/main/java/com/capitalone/dashboard/util/ClientUtil.java b/collectors/feature/jira/src/main/java/com/capitalone/dashboard/util/ClientUtil.java
@@ -186,7 +186,7 @@ public JSONObject toCanonicalSprintJSON(String nativeRs) {
 		if ((nativeRs != null) && !(nativeRs.isEmpty())) {
 			start = nativeRs.indexOf('[') + 1;
 			end = nativeRs.length() - 1;
-			StringBuffer interrimBuf = new StringBuffer(nativeRs);
+			StringBuilder interrimBuf = new StringBuilder(nativeRs);
 			interrimChar = interrimBuf.subSequence(start, end);
 			String interrimStr = interrimChar.toString();
 

diff --git a/hygieia-jenkins-plugin/src/main/java/hygieia/utils/WildCardURL.java b/hygieia-jenkins-plugin/src/main/java/hygieia/utils/WildCardURL.java
@@ -92,7 +92,7 @@ public String getHost() {
      */
     public String getAuthority() {
         String userInfo = getUserInfo();
-        StringBuffer auth = new StringBuffer();
+        StringBuilder auth = new StringBuilder();
         if(!"*".equals(userInfo)) {
             auth.append(userInfo).append("@");
         }