Minor additions to the software framework #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README with how to lint ignore lines Add resultant binary to .gitignore
brano2
reviewed
Feb 19, 2018
|
Sorry, we do not. I only used it for testing pre-commit hook. I needing some change to make a commit. Will remove the temp file and recommit shortly. |
|
Can you also add a note to the README regarding the linter not being 100% accurate and style guide having preference? |
|
No, I would prefer first changing the linter to reflect the style guide. Do not approve yet then, we shall resolve the inconsistencies together. |
There is now a separate target to allow for `make clean`ing of linter's stuff only so that you can re-lint without recompiling. Also, `make` now first compiles the project and then lints. It is more important to have code that compiles than code that lints (although the latter is still super important).
|
Any comments @mkristien? |
|
looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README with how to lint ignore lines
Add resultant binary to .gitignore
Add compilation flags to Makefile