New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add payout proposal component #27
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hypedao/hype-dao/A2LUkjXgMzU7Z4wAnmh21JKdtL6P |
Lets have some more helpful error text for invalid urls like pointing them to the Sputnik HypeDao. I sat around for a little bit wondering how I was getting the a wrong url until I realized I was trying to use a forum url not the sputnik one |
Not sure if this was a bug or not but I wasn't able to choose myself as a recipient for the payout, I kept getting the error message "you are logged in as ev3reth-test.testnet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left a few comments about minor things I'd like changed before we merge this.
Hey @EV3RETH, so going through your comments ;-)
The drop-down is disabled on purpose, since we're only supporting payout proposals for now. I think, I'll add a notice to it, saying stating that.
Ok, that's weird. It should only check for a valid URL in general, not a specific domain. I'll have a look!
Ok, that muss be small boolean-flip in the React component. One can pass a flag to
Noted. Will fix! |
@EV3RETH Updated. All the issues mentioned should be fixed now. After merging this, we'll need to set a custom build command in Vercel on
|
No description provided.