Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payout proposal component #27

Merged
merged 9 commits into from Oct 4, 2021
Merged

Add payout proposal component #27

merged 9 commits into from Oct 4, 2021

Conversation

erak
Copy link
Collaborator

@erak erak commented Oct 2, 2021

No description provided.

@vercel
Copy link

vercel bot commented Oct 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hypedao/hype-dao/A2LUkjXgMzU7Z4wAnmh21JKdtL6P
✅ Preview: https://hype-dao-git-feature-payout-proposal-hypedao.vercel.app

@EV3RETH
Copy link
Collaborator

EV3RETH commented Oct 2, 2021

It feels like I should be able to choose an option here but I cant.

Screen Shot 2021-10-02 at 3 55 23 PM

@EV3RETH
Copy link
Collaborator

EV3RETH commented Oct 2, 2021

Lets have some more helpful error text for invalid urls like pointing them to the Sputnik HypeDao. I sat around for a little bit wondering how I was getting the a wrong url until I realized I was trying to use a forum url not the sputnik one

@EV3RETH
Copy link
Collaborator

EV3RETH commented Oct 2, 2021

Not sure if this was a bug or not but I wasn't able to choose myself as a recipient for the payout, I kept getting the error message "you are logged in as ev3reth-test.testnet"

@EV3RETH
Copy link
Collaborator

EV3RETH commented Oct 2, 2021

Upon completion I'm getting some overlap with the check sign (I'm using Chrome)
Screen Shot 2021-10-02 at 4 04 20 PM

Copy link
Collaborator

@EV3RETH EV3RETH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a few comments about minor things I'd like changed before we merge this.

@erak
Copy link
Collaborator Author

erak commented Oct 4, 2021

Hey @EV3RETH, so going through your comments ;-)

It feels like I should be able to choose an option here but I cant.

The drop-down is disabled on purpose, since we're only supporting payout proposals for now. I think, I'll add a notice to it, saying stating that.

Lets have some more helpful error text for invalid urls like pointing them to the Sputnik HypeDao. I sat around for a little bit wondering how I was getting the a wrong url until I realized I was trying to use a forum url not the sputnik one

Ok, that's weird. It should only check for a valid URL in general, not a specific domain. I'll have a look!

Not sure if this was a bug or not but I wasn't able to choose myself as a recipient for the payout, I kept getting the error message "you are logged in as ev3reth-test.testnet"

Ok, that muss be small boolean-flip in the React component. One can pass a flag to checkAccountAvailable in the near hook, to define if the own account should be valid. Here, it should be allowed. It shouldn't when we send HYPE.

Upon completion I'm getting some overlap with the check sign

Noted. Will fix!

@erak erak changed the title Add payout proposal Add payout proposal component Oct 4, 2021
@erak
Copy link
Collaborator Author

erak commented Oct 4, 2021

@EV3RETH Updated. All the issues mentioned should be fixed now. After merging this, we'll need to set a custom build command in Vercel on main in order to build for Mainnet*:
echo NEAR_ENV=mainnet > .env.local. The file is picked up by the Next config with this PR.

  • This can be done by going to the Vercel project, then Settings -> Project settings -> Build & Development Settings -> Build command

@EV3RETH EV3RETH merged commit e2017c0 into main Oct 4, 2021
@EV3RETH EV3RETH deleted the feature/payout-proposal branch October 4, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants