Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create $HYPE leaderboard #8

Merged
merged 4 commits into from Sep 7, 2021
Merged

Create $HYPE leaderboard #8

merged 4 commits into from Sep 7, 2021

Conversation

erak
Copy link
Collaborator

@erak erak commented Aug 20, 2021

Adds a $HYPE balances board, sorted by amount in an ascending order, available via the route token/board. This PR does the following:

  • Introduces application-wide state meant to be shared between components
  • Make wallet connection available in application-wide state
  • Introduces a $HYPE token board, hard-coded account list
  • Makes $HYPE token board accessible through main navigation

Please check https://gov.near.org/t/dev-hype-leaderboard/4761 for further discussion.

@vercel
Copy link

vercel bot commented Aug 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hypedao/hype-dao/Dr7Pa73U7wX92WvyZqwSmp8bAuNf
✅ Preview: https://hype-dao-git-fork-erak-hype-board-hypedao.vercel.app

@EV3RETH
Copy link
Collaborator

EV3RETH commented Aug 22, 2021

@erak Thank you for the work thus far!

I've left some comments in forum https://gov.near.org/t/dev-hype-leaderboard/4761

Also the build has failed. I know this is a work in progress, but I wanted to give you the error context in case you aren't able to access the build logs .
Screen Shot 2021-08-22 at 3 23 45 PM

@erak erak changed the title [WIP] Create $HYPE board Create $HYPE leaderboard Sep 4, 2021
@erak erak requested a review from EV3RETH September 4, 2021 10:02
EV3RETH
EV3RETH previously approved these changes Sep 4, 2021
Copy link
Collaborator

@EV3RETH EV3RETH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things

  1. If you could rename the tsx and css files involved from "menu" to "hype-menu" I think that will avoid us some confusion down the line if we happen to add other menu components.
  2. The menu is blocking the Nav menu when on mobile view. In addition to avoiding this I think it would be cool to add some entry animation. We can do both of these things by with the following.
.hypeMenu {
	opacity: 0;
	position: absolute;
	top: -70px;
	padding: 0;
	justify-content: space-between;
	align-items: center;
	z-index: -1;
	background: linear-gradient(315deg, var(--main-gradient));
	border-radius: 1rem;
	box-shadow: 0px 0px 0px 0px rgba(0, 0, 0, 1);
	transition: 0.3s ease-in-out;
	list-style-type: none;
}
.hypeMenu.isOpen {
	z-index: 9;
	opacity: 1;
	top: 50px
}
  1. Looks like there are some merge conflicts with the lock files.

Over all really great work, I cant wait for folks to start using this. And I really cant wait for the Send button to show up again! (when its functioning of course)

@EV3RETH
Copy link
Collaborator

EV3RETH commented Sep 5, 2021

Oh and actually I just thought about this, we should really only be using yarn.lock
If you can managed to get rid of the package-lock.json that would be appreciated.

@erak
Copy link
Collaborator Author

erak commented Sep 5, 2021

@EV3RETH I think you need to merge this.

@EV3RETH EV3RETH merged commit 6732626 into HypeDAO:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants