Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually show progress for deep link interactions forwarded to my phone. #22

Closed
jacobc-eth opened this issue Sep 23, 2022 · 1 comment
Closed

Comments

@jacobc-eth
Copy link
Contributor

jacobc-eth commented Sep 23, 2022

As a player, I would like to see feedback or visual acknowledgement of transactions sent to my mobile device, so that I know I need to approve a transaction on my mobile device.

description

In addition to the overlay view for the browser extension wallet, we also need to implement an overlay solution for when people are using an external signer (mobile wallet). This view is used to notify the user they have a pending transaction on the external signer, and should be triggered automatically upon transaction/signature request. The mobile itself doesn't need to have the details of the transaction, it just needs to tell the user that a confirmation is pending on their mobile device.

Sample text:

(Title of the confirmation type, see below for titles)

(Logo of connect method user chose)

"A wallet confirmation is pending on your mobile wallet."(This generic copy can be used on all confirmation pending screens, but hide it once the user has submitted)

(loading spinner)

Acceptance criteria

  • Trigger on any type of wallet confirmation (transaction, signature, custom network approval, custom token approval, etc).

Connection requestion titles (we can reuse this for reconnection requests too):
"Wallet connection requested"
"Wallet connection approved"

Transaction request titles:

"Transaction request pending"
"Transaction submitted"
"Transaction confirmed"

Signature request:

"Signature request pending"
"Signature submitted"
"Signature confirmed"

Add custom network request:

"Add custom network request pending"
"Add custom network confirmed

Add custom token:

"Add custom token request pending"
"Add custom token confirmed"

@jacobc-eth jacobc-eth changed the title Visually show progress for deep link interacitons forwarded to my phone. Visually show progress for deep link interactions forwarded to my phone. Oct 3, 2022
@jacobc-eth jacobc-eth changed the title Visually show progress for deep link interactions forwarded to my phone. Visually show progress for deep link interactions from Browser games forwarded to my phone. Oct 14, 2022
@camgreenburg camgreenburg changed the title Visually show progress for deep link interactions from Browser games forwarded to my phone. Visually show progress for deep link interactions forwarded to my phone. Oct 14, 2022
@biliesilva
Copy link

biliesilva commented Oct 14, 2022

Here the modals for the mobile transactions feedback:
We need to have some animations in the icons to show feedback that something is loading (using the loading spinner and the gradient color). On Figma you can see the other screens with different titles:

image.png

you can find the other modal requests here:
https://www.figma.com/file/GKPELZxk551oVC3EDLgEDA/HyperPlay-Game-Launcher?node-id=614%3A4187&t=cgNp71SbX7YfoUbr-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants