Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have any transactions pop up within the context of the game I'm playing #55

Closed
jacobc-eth opened this issue Dec 5, 2022 · 7 comments
Closed

Comments

@jacobc-eth
Copy link
Contributor

As a gamer I want to have wallet interactions appear in context while I am playing a game and not require me to switch screens, applications, or devices to complete the interaction.

Acceptance criteria

  • depending on design, this should be an overlay on-top of the game.
  • should handle all types of wallet interactions available via the proxy-library
@pimentel08
Copy link

@BrettCleary what type of transactions should we design for

@biliesilva
Copy link

@jacobc-eth
Copy link
Contributor Author

jacobc-eth commented Dec 22, 2022

Yes, #22 deals with the details of what the popup shows when a transaction is pending. This story is making the overlay functionality itself work. I think the only kind of design work we need on this card is how the overlay itself looks (is there a blurring effect, a generic modal box, etc). @biliesilva

@pimentel08 pimentel08 assigned biliesilva and unassigned pimentel08 Jan 9, 2023
@biliesilva
Copy link

biliesilva commented Jan 11, 2023

We decided to use notifications and the UI is ready:
Notification1.pngNotification2.pngNotification3.pngNotification4.png

image.png

Figma Link

@pimentel08
Copy link

Feedback:

  • fix padding around to keep consistency of: 12px
  • reduce alerts to: 420px to match existing modals
  • reduce image size of illustration to 80px
  • move "x" icon into the Icon + Text auto-layout layer (this will allow the full text to show without the "x" getting in the way for these smaller cards
  • create component and add to library once template is ready

@biliesilva
Copy link

Done! :)

@pimentel08
Copy link

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants