Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Update download manager page #911

Merged
merged 15 commits into from
May 30, 2024
Merged

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented May 25, 2024

Update download manager to latest designs.

Refactors some css files to scss modules.

Does not update the graphs or progress bar, only the tables, tabs, background.

figma https://www.figma.com/design/GKPELZxk551oVC3EDLgEDA/Current-Design?node-id=2574-23537&t=YWPTCdiwb5ARsUJ0-4

image

@BrettCleary BrettCleary self-assigned this May 25, 2024
@BrettCleary BrettCleary marked this pull request as ready for review May 28, 2024 17:59
@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label May 28, 2024
@flavioislima
Copy link
Contributor

Testing here.
Overall pretty nice changes.

One thing I noticed on the Downloaded tab is that there is no action button. Perhaps adding a Play button there for the finished would be nice. It could either launch the game or navigate to the game page that is simpler to implement.

image

@flavioislima
Copy link
Contributor

Another thing I noticed is that the Cancel button doesn't show the cancel dialog anymore. It simply removes the game from the list without confirmation.

Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, I only have a couple comments

src/frontend/screens/DownloadManager/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/DownloadManager/index.tsx Outdated Show resolved Hide resolved
@BrettCleary
Copy link
Collaborator Author

Testing here. Overall pretty nice changes.

One thing I noticed on the Downloaded tab is that there is no action button. Perhaps adding a Play button there for the finished would be nice. It could either launch the game or navigate to the game page that is simpler to implement.

image

ah. I forgot to pass some state to the download manager table and to set the fill on the icons. updated now. icons centered and download icon switched over as well

@BrettCleary
Copy link
Collaborator Author

Another thing I noticed is that the Cancel button doesn't show the cancel dialog anymore. It simply removes the game from the list without confirmation.

can you try again? I cannot replicate this with the latest changes
image

@BrettCleary
Copy link
Collaborator Author

I believe all comments are addressed @flavioislima @eliobricenov

Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks perfect now!

@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels May 28, 2024
@nyghtstalker
Copy link

  1. "Nothing to download" is no longer displayed like before

image

  1. Download graph remains after download finishes and after canceling the download. It is displayed on all tabs.

image
image
image

  1. Clicking the game name or Play button takes the user to the game page. Using the back button or mouse back button takes the user to the Downloading page instead of the Downloaded page they were on previously.

image
image

  1. Cancels are not displayed in the list

image

@BrettCleary
Copy link
Collaborator Author

  1. "Nothing to download" is no longer displayed like before

  2. Download graph remains after download finishes and after canceling the download. It is displayed on all tabs.

  3. Clicking the game name or Play button takes the user to the game page. Using the back button or mouse back button takes the user to the Downloading page instead of the Downloaded page they were on previously.

  4. Cancels are not displayed in the list

  1. this is fine. showed @pimentel08 and got approval for this iteration as well
  2. I think this is fine too. probably better than having layout shift showing and hiding it, but we can send a follow up pr optimizing that if needed
  3. I think this is fine too and a small optimization that will take more engr time than it is worth
  4. I can see cancels on mine

image

Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Canceling during extraction looks to be the issue. If you cancel during extraction it shows up as successful and not canceled. I first canceled during download and it did show up as canceled in the list. Then I canceled it during extraction and the canceled went away. Unfortunately, this same behavior is in PROD.

@BrettCleary BrettCleary merged commit 6740455 into main May 30, 2024
15 of 16 checks passed
@BrettCleary BrettCleary deleted the ui/update_download_manager_page branch May 30, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants