-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Update download manager page #911
Conversation
Another thing I noticed is that the Cancel button doesn't show the cancel dialog anymore. It simply removes the game from the list without confirmation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, I only have a couple comments
ah. I forgot to pass some state to the download manager table and to set the fill on the icons. updated now. icons centered and download icon switched over as well |
I believe all comments are addressed @flavioislima @eliobricenov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! looks perfect now!
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Canceling during extraction looks to be the issue. If you cancel during extraction it shows up as successful and not canceled. I first canceled during download and it did show up as canceled in the list. Then I canceled it during extraction and the canceled went away. Unfortunately, this same behavior is in PROD.
Update download manager to latest designs.
Refactors some css files to scss modules.
Does not update the graphs or progress bar, only the tables, tabs, background.
figma https://www.figma.com/design/GKPELZxk551oVC3EDLgEDA/Current-Design?node-id=2574-23537&t=YWPTCdiwb5ARsUJ0-4