Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registerCustomProtocol breaks e-mail linkification #414

Closed
t3chguy opened this issue Nov 21, 2022 · 1 comment · Fixed by #417
Closed

registerCustomProtocol breaks e-mail linkification #414

t3chguy opened this issue Nov 21, 2022 · 1 comment · Fixed by #417

Comments

@t3chguy
Copy link

t3chguy commented Nov 21, 2022

Using registerCustomProtocol("matrix", true); causes matrix@example.com to not be linkified as an email, instead only example.com get linkified.

Downstream issue element-hq/element-web#23806
Possibly related #410
hanazuki added a commit to hanazuki/linkifyjs that referenced this issue Dec 16, 2022
@hanazuki
Capture email address with its local part being scheme string
a68c8fc 
This patch fixes the parser so that it can capture an email address
whose local part matches a scheme string, e.g. 'http' or 'mailto'.

Fixes Hypercontext#414
@hanazuki hanazuki mentioned this issue Dec 16, 2022
Merged
hanazuki added a commit to hanazuki/linkifyjs that referenced this issue Dec 16, 2022
@hanazuki
Capture email address with its local part being scheme string
81614d9 
This patch fixes the parser so that it can capture an email address
whose local part matches a scheme string, e.g. 'http' or 'mailto'.

Fixes Hypercontext#414
@hanazuki
Copy link
Contributor

It seems the same problem happens for the predefined protocols such as http and mailto, that is, http@example.com is not linkified as email. I just submitted a pull request to fix this issue: #417

nfrasser pushed a commit that referenced this issue Jan 3, 2023
@hanazuki
Capture email address with its local part being scheme string (#417)
ba048e0 
This patch fixes the parser so that it can capture an email address
whose local part matches a scheme string, e.g. 'http' or 'mailto'.

Fixes #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Capture email address with its local part being scheme string hanazuki/linkifyjs
2 participants
@hanazuki @t3chguy