feat: SM2Util 支持通过密钥对和证书的字符串形式加载其对象 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
首先 我们启用了DCO检测，请依据DCO检测的提示修改提交的信息。 |
SamYuan1990
reviewed
Dec 3, 2023
src/test/java/SM2UtilTest.java
Outdated
| @Test | ||
| public void testLoadPrivFromString() throws Exception { | ||
| InputStream in = SM2UtilTest.class.getResourceAsStream("testdata.yml"); | ||
| Map<String, Map<String, Object>> configMap = ConfigLoader.loadConfig(in); |
There was a problem hiding this comment.
完全可以弄一个全局变量吧？没必要copy paste yourself
Signed-off-by: photowey <photowey@gmail.com>
photowey
force-pushed
the
feature/loadkeystr
branch
from
4cd7428
to
a757e30
Compare
Signed-off-by: photowey <photowey@gmail.com>
photowey
force-pushed
the
feature/loadkeystr
branch
from
03ed3bd
to
8cbae2c
Compare
|
@ryjones or @davidkhala , could you please help check our CI. It seems just DCO is running. |
|
it was disabled by github as it has not run in over 90 days. I've re-enabled it. @SamYuan1990 it should run on the next push to the PR |
thanks @ryjones , @photowey , could you please make a dummy commit so that we can trigger CI? |
|
OK |
Signed-off-by: photowey <photowey@gmail.com>
photowey
force-pushed
the
feature/loadkeystr
branch
from
d33dd56
to
d418970
Compare
Signed-off-by: photowey <photowey@gmail.com>
Signed-off-by: photowey <photowey@gmail.com>
|
update PR description and merge. |
|
@photowey thanks for your contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SM2Util#loadPrivFromString;SM2Util#loadPublicFromString;SM2Util#loadX509CertificateFromString;