Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection retry #117

Closed
SamYuan1990 opened this issue Dec 6, 2020 · 6 comments · Fixed by #124
Closed

connection retry #117

SamYuan1990 opened this issue Dec 6, 2020 · 6 comments · Fixed by #124

Comments

@SamYuan1990
Copy link
Member

Is your proposal related to a problem?

Some time fails create connection between tape and peer.

Describe the solution you'd like

add a general 3 times retry for connection creation before error.

Describe alternatives you've considered

N/A

Additional context

N/A

@stone-ch
Copy link
Member

stone-ch commented Dec 6, 2020

Would connection retry cost more time when calculate the tps?

@SamYuan1990
Copy link
Member Author

Would connection retry cost more time when calculate the tps?

no, just retry to set up connection.
Tape works as set up connection and send test data.
the calculation starts form data send.

@guoger
Copy link
Member

guoger commented Dec 7, 2020

this looks good to me

@SamYuan1990
Copy link
Member Author

https://github.com/grpc/grpc-go/blob/02cd07d9bb5609fe76f8bb8d948037e79a8b29c7/examples/features/retry/README.md

https://github.com/hyperledger/fabric/blob/master/internal/pkg/comm/client.go#L178

for my understanding... it seems that fabric client code invokes grpc from it's vendor folder.
which is a/an old version of grpc code which doesn't support retry feature in latest grpc?

@guoger

@guoger
Copy link
Member

guoger commented Dec 11, 2020

  • we could always retry at application layer, or
  • we could always switch to latest grpc-go if necessary

@SamYuan1990
Copy link
Member Author

ok, let's make it at application layer.

SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Dec 12, 2020
fix for Hyperledger-TWGC#117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Dec 15, 2020
fix for Hyperledger-TWGC#117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Dec 15, 2020
fix for Hyperledger-TWGC#117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Dec 15, 2020
fix for Hyperledger-TWGC#117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Dec 25, 2020
fix for Hyperledger-TWGC#117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Dec 29, 2020
fix for Hyperledger-TWGC#117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990 added a commit to SamYuan1990/tape that referenced this issue Dec 29, 2020
fix for Hyperledger-TWGC#117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
guoger pushed a commit that referenced this issue Jan 3, 2021
fix for #117

Signed-off-by: SamYuan1990 <yy19902439@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants