-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple peer client support #10
Conversation
go run main.go config.json 100 Time 0.18s Block 54 Tx 10 |
@guoger , please help check pipeline error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much simpler than previous iteration, thx
pls remove unneeded code
d07dfdc
to
ccb4682
Compare
ccb4682
to
d0e3975
Compare
d0e3975
to
ead826c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as i commented inline, we need to supply correct crypto materials (priv_key, certificate, etc) for different peers. As code currently stands, it would fail to establish tls connections
also, i believe i've fixed azure pipeline. pls do a rebase |
ead826c
to
8558ff9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than several nits in code, i'm seeing ~25% performance regression.. i suspect that's caused by excessive lock/unlock... need more proofs though
8558ff9
to
d24684b
Compare
d24684b
to
b9f70a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
although it's rather confusing to have both config.json
and config_sample.json
with almost identical content..
"version": "", | ||
"args": ["query","a"], | ||
"mspid": "Org1MSP", | ||
"private_key": "./crypto-config/peerOrganizations/org1.example.com/users/User1@org1.example.com/msp/keystore/4d75bedcf454389483dfe0efbf12602b64d8c0e2903451c688b1d5d9ba38e655_sk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in newer fabric, private key file is renamed to priv_sk
(which is quite convenient for us)
support multiple peer client as endorsement police "org1 and org2"