当err为nil时，输出错误原因 #105
Merged
当err为nil时，输出错误原因 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tianxuanhong <523713078@qq.com>
guoger
requested changes
Nov 20, 2020
pkg/infra/proposer.go
Outdated
| p.logger.Errorf("Err processing proposal: %s, status: %d, addr: %s \n", err, r.Response.Status, p.Addr) | ||
| if r.Response.Status < 200 || r.Response.Status >= 400 { | ||
| if err == nil{ | ||
| p.logger.Errorf("Err processing proposal: %s \n",r.Response) |
There was a problem hiding this comment.
感谢贡献
这里的case已经被原来76行覆盖了吧？即 err == nil && (r.Response.Status < 200 || r.Reponse.Status >= 400)
There was a problem hiding this comment.
这个修改是因为 #97 问题，我也遇到了，err为nil时，没看到错误原因。输出r.Response后类似未上传链码错误会输出："status:500 message：cannot retrieve package for chaincode mycc/v2, error open /var/hyperledger/production/chaincodes/mycc.v2: no such file or directory", 可能会帮助一些遇到类似问题的人清楚问题原因。 原来76行的代码err ==nil &&(r.Response.Status < 200 || r.Reponse.Status >= 400)这个我没注意到是在哪次修改里，最新代码好像不是。。
There was a problem hiding this comment.
哦我知道了，这里只需要在原来的76行，把 r.Response.Message 也打印出来，就ok了吧？
Signed-off-by: tianxuanhong <523713078@qq.com>
guoger
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tianxuanhong 523713078@qq.com