Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce kingpin as the cmd framework #119

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

wuxuer
Copy link
Contributor

@wuxuer wuxuer commented Dec 7, 2020

Currently, only the run and help subcommand is introduced.
Run subcommand has two flags: config and number.
Config flag is the config file's path, whose short flag name is -c.
Number flag is the number of tx for shot, whose short flag name is -n.
Help subcommand just show context-sensitive help, which is provided by the framework.

It's the first change to fix #113 .

Signed-off-by: wuxu wuxu1103@163.com

Copy link
Member

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR/Code/Contribution. General speaking, I am good with the design and the impl. I left some questions and curious, as I do not have enough knowledge with kingpin project.
BTW, please update your branch to latest master.

e2e/e2e_test.go Show resolved Hide resolved
pkg/infra/process.go Outdated Show resolved Hide resolved
pkg/infra/process.go Outdated Show resolved Hide resolved
pkg/infra/process.go Outdated Show resolved Hide resolved
@wuxuer wuxuer force-pushed the kingpin branch 2 times, most recently from c9fbec7 to ad1da7f Compare December 8, 2020 02:12
Currently, only the run and help subcommands are introduced.
Run subcommand has two flags: config and number.
Config flag is the config file's path, whose short flag name is -c.
Number flag is the number of tx for shot, whose short flag name is -n.
Help subcommand just show context-sensitive help, which is provided by the framework.

Signed-off-by: wuxu <wuxu1103@163.com>
@SamYuan1990 SamYuan1990 merged commit 8074b32 into Hyperledger-TWGC:master Dec 11, 2020
@wuxuer wuxuer deleted the kingpin branch December 12, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

tape version should return current version of binary in use
3 participants