Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl for e2e enhancement #135

Merged
merged 1 commit into from
Feb 25, 2021
Merged

impl for e2e enhancement #135

merged 1 commit into from
Feb 25, 2021

Conversation

SamYuan1990
Copy link
Member

  • refactor e2e structure to avoid super test case
  • add test case for multi Peers

Signed-off-by: SamYuan1990 yy19902439@126.com

@SamYuan1990
Copy link
Member Author

SamYuan1990 commented Jan 25, 2021 •
edited

@guoger , 看起来template的loop和if不能复用，所以我就先写成现在这样if else两个template了。
因为在loop中好像无法拿到loop外的变量。

value:
addrs: []str
mtls: bool

loop addrs
if mtls...//这里会找不到 因为addrs str没有这个叫做mtls的对象
end

对应到我们mtls的那个bool检测。。。

guoger
guoger requested changes Feb 7, 2021
View reviewed changes
e2e/e2e_errCase_test.go Outdated Show resolved Hide resolved
e2e/e2e_multiPeer_test.go Outdated Show resolved Hide resolved
e2e/e2e_singlePeer_test.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/util.go Outdated Show resolved Hide resolved
@SamYuan1990 SamYuan1990 mentioned this pull request Feb 8, 2021
Closed
@SamYuan1990 SamYuan1990 force-pushed the testEnhancement branch 3 times, most recently from 21556d1 to 241b07d Compare February 10, 2021 12:22
guoger
guoger requested changes Feb 17, 2021
View reviewed changes
Copy link
Member

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the modification to mock server.

e2e/multi_peer_test.go Outdated Show resolved Hide resolved
e2e/util.go Outdated Show resolved Hide resolved
e2e/util.go Outdated Show resolved Hide resolved
e2e/util.go Outdated Show resolved Hide resolved
e2e/mock/orderer.go Outdated Show resolved Hide resolved
@SamYuan1990 SamYuan1990 force-pushed the testEnhancement branch 2 times, most recently from 73996e4 to 6851944 Compare February 23, 2021 11:51
guoger
guoger requested changes Feb 24, 2021
View reviewed changes
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/util.go Outdated Show resolved Hide resolved
guoger
guoger reviewed Feb 24, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@guoger
Copy link
Member

guoger commented Feb 24, 2021

also, i think we could have a followup PR to add peer.Pause() and peer.Resume(), so we could assert that threshold takes effect when 2/5 peers are paused

@SamYuan1990 SamYuan1990 mentioned this pull request Feb 24, 2021
Closed
guoger
guoger requested changes Feb 24, 2021
View reviewed changes
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/peer.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/orderer.go Outdated Show resolved Hide resolved
e2e/mock/orderer.go Outdated Show resolved Hide resolved
guoger
guoger reviewed Feb 24, 2021
View reviewed changes
e2e/mock/server.go Outdated Show resolved Hide resolved
guoger
guoger reviewed Feb 24, 2021
View reviewed changes
e2e/mock/server.go Outdated Show resolved Hide resolved
guoger
guoger reviewed Feb 24, 2021
View reviewed changes
e2e/mock/server.go Outdated Show resolved Hide resolved
guoger
guoger reviewed Feb 24, 2021
View reviewed changes
e2e/multi_peer_test.go Outdated Show resolved Hide resolved
guoger
guoger reviewed Feb 24, 2021
View reviewed changes
pkg/infra/proposer_test.go Outdated Show resolved Hide resolved
guoger
guoger requested changes Feb 24, 2021
View reviewed changes
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
e2e/multi_peer_test.go Outdated Show resolved Hide resolved
e2e/mock/peer.go Outdated Show resolved Hide resolved
e2e/mock/orderer.go Outdated Show resolved Hide resolved
@guoger
Copy link
Member

guoger commented Feb 24, 2021

introduction of constructors make code much cleaner now :) we are almost there other than some nits

@SamYuan1990 SamYuan1990 force-pushed the testEnhancement branch 2 times, most recently from 210789f to c324b4a Compare February 25, 2021 10:56
guoger
guoger requested changes Feb 25, 2021
View reviewed changes
e2e/mock/orderer.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
@SamYuan1990
impl for e2e enhancement
873f011 
- refactor e2e structure to avoid super test case
- add test case for multi Peers

Signed-off-by: SamYuan1990 <yy19902439@126.com>
guoger
guoger approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guoger guoger enabled auto-merge (rebase) February 25, 2021 15:16
@guoger guoger merged commit 3144029 into Hyperledger-TWGC:master Feb 25, 2021
@SamYuan1990 SamYuan1990 deleted the testEnhancement branch January 2, 2022 12:14
@SamYuan1990 SamYuan1990 restored the testEnhancement branch January 2, 2022 12:14
@SamYuan1990 SamYuan1990 deleted the testEnhancement branch January 2, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoger guoger guoger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SamYuan1990 @guoger