Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nitfixing24 #232

Merged
merged 7 commits into from
Jan 17, 2022
Merged

Nitfixing24 #232

merged 7 commits into from
Jan 17, 2022

Conversation

SamYuan1990
Copy link
Member

  • FAQ in error msg
  • fabric 2.4 in CI
  • doc update

@SamYuan1990
Copy link
Member Author

fix ci error

davidkhala
davidkhala reviewed Dec 31, 2021
View reviewed changes
test/bootstraps/bootstrap-v2.4.sh
@@ -0,0 +1,198 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一段是从fabric-sample那复制过来的么？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是

davidkhala
davidkhala reviewed Dec 31, 2021
View reviewed changes
test/integration-test.sh
Comment on lines +68 to +69
# Why comment following code? Please check this issue: https://github.com/Hyperledger-TWGC/tape/issues/159
# curl -vsS https://raw.githubusercontent.com/hyperledger/fabric/release-2.3/scripts/bootstrap.sh | bash
Copy link
Member

@davidkhala davidkhala Dec 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我第一眼看这一段有点懵，后来明白了，要不这样写? 合并成一行

# We intentionally do not use `curl -vsS https://raw.githubusercontent.com/hyperledger/fabric/release-2.3/scripts/bootstrap.sh | bash` due to tape issue #159

@davidkhala
Copy link
Member

davidkhala commented Dec 31, 2021 •
edited
Loading

这里拿不到 ${{ secrets.TWGC_DAVIDKHALA }}有点神奇，估计是fork拿不到credential的缘故

davidkhala
davidkhala previously approved these changes Dec 31, 2021
View reviewed changes
@SamYuan1990 SamYuan1990 marked this pull request as draft December 31, 2021 11:28
@SamYuan1990
nit fixing add CI with 2.4 fabric
0f4dbcf 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up
ecc7a66 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up
3f09bc6 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up
4e255ad 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 marked this pull request as ready for review December 31, 2021 11:42
@SamYuan1990
fix git workflow and fix go doc
6796142 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up resolve Hyperledger-TWGC#233
e918137 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 marked this pull request as draft January 3, 2022 10:49
@SamYuan1990 SamYuan1990 marked this pull request as ready for review January 3, 2022 15:20
@guoger
Copy link
Member

guoger commented Jan 11, 2022

LGTM

@davidkhala davidkhala merged commit e91bdae into Hyperledger-TWGC:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stone-ch stone-ch Awaiting requested review from stone-ch

@guoger guoger Awaiting requested review from guoger

@davidkhala davidkhala Awaiting requested review from davidkhala

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamYuan1990 @davidkhala @guoger