Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: create & modify viewpoints #106

Merged
merged 10 commits into from Jun 13, 2018
Merged

Conversation

perfectstrong
Copy link

Content

By using Outliner from #69, this feature allows user to:

  • Create a new viewpoint by clicking a button in Portfolio, which then open the viewpoint page in which user is free to name the new viewpoint and create new subtopics as well. Test included.
  • Consult and modify topics (editing, dragging & dropping, removing from viewpoint). Test not included yet.

Close #92, #58.


Checklist

Please check that your pull request is correct:

  • Each commit:
    • corresponds to a contribution that should be notified to users,
    • does not generate new errors or warnings at compile or test time,
    • must be attributed to its real authors (with correct GitHub IDs and correct syntax for multiple authors).
  • The title of a commit should:
    • begin with a contribution type
      • FEATURE for a behaviour allowing a user to do something new,
      • FIX for a behaviour which has been changed in order to meet user’s expectations,
      • TEST when it concerns an acceptance test,
      • PROCESS for a change in the way the software is built, tested, deployed,
      • DOC when it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),
    • be followed by a colon (:) with one space after and no space before,
    • be followed by a title as short, as user-centered and as explicit as possible
      • If it is a feature, the title must be the user action (beginning with a verb, and please not manage),
      • If it is a fix, the title must describe the intended behavior (with should).
    • ends with a reference to the corresponding ticket with the following syntax:
      • (closes #xx) if xx is a feature ticket (and the commit is a complete implementation),
      • (fixes #xx) if xx is a fix ticket (and the commit is a complete fix),
      • (see #xx) otherwise,
  • Each committed line is:
    • useful (it would not work if removed)
      • if it is a comment line, its information could not be conveyed by better variables and function naming, better code structuring, or better commit message,
    • related to this very contribution (feature, fix...),
    • in English (with the exception of Gherkin scenarios in French and resulting steps),
    • without any typo in variable, class or function names,
    • correctly indented (spaces rather than tabs, same number of characters as in the rest of the file).

Copy link
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A part of your code seems to be from a third party library (probably React-UI-Tree).
Third party libraries should be referenced in package.json rather than being copy-pasted.

@xuzhengyi1995
Copy link

Because the library React-UI-Tree doesn't have the function of delete/edit/add, we have modify the library for support these functions. We are sorry but it's not the original library so we can't reference it directly in package.json.

@benel
Copy link
Member

benel commented Jun 13, 2018

Because the library React-UI-Tree doesn't have the function of delete/edit/add, we have modify the library for support these functions. We are sorry but it's not the original library so we can't reference it directly in package.json.

Then the clean (and legal) way is to fork the library and create your own...

@benel
Copy link
Member

benel commented Jun 13, 2018

Then the clean (and legal) way is to fork the library and create your own..

You can also adapt an existing React.Component through composition (rather than inheritance).

xuzhengyi1995 pushed a commit to perfectstrong/Porphyry that referenced this pull request Jun 13, 2018
@xuzhengyi1995
Copy link

I have created my own library and modified the Outliner.

@benel
Copy link
Member

benel commented Jun 13, 2018

I have created my own library and modified the Outliner.

Great!

Your contribution would be perfect if you could now join both of your commits into a single one (like we did in git-graal tutorial).

Note: If you want to push it in the same pull request, you'll have to force it (with -f).

@xuzhengyi1995 xuzhengyi1995 force-pushed the Outliner branch 3 times, most recently from 0c0c6ab to 5c3fc6c Compare June 13, 2018 11:57
xuzhengyi1995 and others added 2 commits June 13, 2018 14:35
…ypertopic#58)

Co-Authored-By: ZHANG Yi <yi.zhang2@utt.fr>
Co-Authored-By: TRAN Quoc Nhat Han <quoc_nhat_han.tran@utt.fr>
Co-Authored-By: Caroline <caroline.dequidt@worldonline.fr>
@xuzhengyi1995
Copy link

Is join both of the commits like this, thank you.

@benel
Copy link
Member

benel commented Jun 13, 2018

Is join both of the commits like this, thank you.

I'm on it. Thanks.

@benel benel merged commit df16aba into Hypertopic:v7 Jun 13, 2018
@benel
Copy link
Member

benel commented Jun 13, 2018

Your contributions are now in branch v7. Well done!

@xuzhengyi1995
Copy link

Thank you!

@gumn gumn mentioned this pull request Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a viewpoint
6 participants