-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: create & modify viewpoints #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A part of your code seems to be from a third party library (probably React-UI-Tree).
Third party libraries should be referenced in package.json
rather than being copy-pasted.
Because the library React-UI-Tree doesn't have the function of delete/edit/add, we have modify the library for support these functions. We are sorry but it's not the original library so we can't reference it directly in |
Then the clean (and legal) way is to fork the library and create your own... |
You can also adapt an existing React.Component through composition (rather than inheritance). |
I have created my own library and modified the Outliner. |
Great! Your contribution would be perfect if you could now join both of your commits into a single one (like we did in git-graal tutorial). Note: If you want to push it in the same pull request, you'll have to force it (with |
0c0c6ab
to
5c3fc6c
Compare
…ypertopic#58) Co-Authored-By: ZHANG Yi <yi.zhang2@utt.fr> Co-Authored-By: TRAN Quoc Nhat Han <quoc_nhat_han.tran@utt.fr> Co-Authored-By: Caroline <caroline.dequidt@worldonline.fr>
Is join both of the commits like this, thank you. |
I'm on it. Thanks. |
Your contributions are now in branch v7. Well done! |
Thank you! |
Content
By using Outliner from #69, this feature allows user to:
Close #92, #58.
Checklist
Please check that your pull request is correct:
FEATURE
for a behaviour allowing a user to do something new,FIX
for a behaviour which has been changed in order to meet user’s expectations,TEST
when it concerns an acceptance test,PROCESS
for a change in the way the software is built, tested, deployed,DOC
when it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),:
) with one space after and no space before,manage
),should
).(closes #xx)
if xx is a feature ticket (and the commit is a complete implementation),(fixes #xx)
if xx is a fix ticket (and the commit is a complete fix),(see #xx)
otherwise,