fix(vendor.viomi): Fix consumables and implement reset capability #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested only on v8 * Values from get_consumables are in hours, not seconds * Implement reset by calling set_consumables: at least 2 parameters are expected, first one in consumable index but the others are unknown, so a 0 is passed I've seen that consumable's lifespan can be greater than 180 (I had 298 hours before doing reset), should the values be updated?
|
Can confirm that it works on v6 firmware. (converted from v8) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Type A:
Type B:
Description (Type A)
Fixes #1061
Feature discussion thread: https://github.com/Hypfer/Valetudo/discussions/1347