Fix for pinch zoom bug in IOS / Safari #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After finally getting IOS to debug on a non-mac host, this PR fixes a pinch zoom issue with Safari on IOS where the pinch zoom becomes uncontrollable. Symptom is after a pinch zoom event, a single finger drag results in the map zooming in / out instead of repositioning the map.
Root cause is with IOS where a single event can have multiple touches registered. This is where a two finger pinch simultaneously has both fingers raised off the screen. Original code only removed one of those touches, leaving an active touch which caused the issue.
Tested with IOS14 / Safari, Edge / Chrome W10 and Android Chrome and appears to fix issue with IOS and not break other devices.