Do not log twice if logfile is the same as stdout redirection #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoors
force-pushed
the
bugfix/duplicate-logs
branch
from
e7431cb
to
adf5523
Compare
ccoors
force-pushed
the
bugfix/duplicate-logs
branch
from
adf5523
to
fa92450
Compare
|
To my surprise, this doesn't break development on windows since the try/catch also catches Neat |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents duplicate log entries if stdlog is redirected to the same file as the actual logfile.
Implementation of
Tools.ARE_SAME_FILESis similar to https://github.com/python/cpython/blob/master/Lib/genericpath.py#L85