Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor(dreame.1C): Add/fix various Map & Volume capabilities #915

Merged
merged 2 commits into from
May 11, 2021

Conversation

FrankZZ
Copy link
Contributor

@FrankZZ FrankZZ commented May 10, 2021

Type of change

Type A:

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor/Code Cleanup
  • Docs
  • Capability implementation for existing core capability
  • New robot implementation

Description (Type A)

Changes that apply to the Dreame 1C:
New Features:

  • add mapResetCapability
  • add persistentMapStateAttribute
  • add "resumable" flag when robot is charging with a current task and will resume when 80% charged
  • enable MapSegmentEditCapability

Fixes:

  • fix "Save volume" - was calling wrong siid
  • fix "Test volume" in sound settings - was calling wrong siid
  • hide edit segment name if robot does not have MapSegmentRenameCapability
  • hide create/split/join segment if robot does not have MapSegmentEditCapability

Refactor:

  • client/settings-persistent-data.js : rename capabilites to capabilities

- add mapResetCapability
- add persistentMapStateAttribute
- fix "Save volume" - was calling wrong siid
- fix "Test volume" in sound settings
- add "resumable" flag when robot is charging with a current task and will resume when 80% charged
- enable MapSegmentEditCapability
@FrankZZ FrankZZ marked this pull request as draft May 10, 2021 21:46
@FrankZZ FrankZZ marked this pull request as ready for review May 10, 2021 22:23
@Hypfer Hypfer merged commit c88df12 into Hypfer:master May 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants