Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No shells in store. [Mod Compat] #38

Open
Sourceshard opened this issue Mar 18, 2024 · 8 comments
Open

No shells in store. [Mod Compat] #38

Sourceshard opened this issue Mar 18, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@Sourceshard
Copy link

Describe the bug

Shotgun Shells are not purchasable in the store. I believe this is a mod compatibility issue. I will continue to track it down. I have no idea why the shotgun would show up but not the shells.

Reproducible Test

018e5313-371e-4779-af24-487827451f98

Anything else?

No response

@Sourceshard Sourceshard added the bug Something isn't working label Mar 18, 2024
@Sourceshard
Copy link
Author

Sourceshard commented Mar 18, 2024

Further testing.

Removing Lethal Level Loader, and all of the mods that use it as a dependency seems to show the real problem.
Apparently, in the base game, there are multiple "Names" for the shotgun shell. Various mods that call this "Name" for any purpose alter the name of the shell and cause it to stop appearing in the store. Too many conflicts cause it to fail to work correctly.

You can see in the below-linked images that the shell possesses multiple overlapping names, and that the item in the store has been named Ammo. It however carries over the price from the BetterShotgun config.

https://cdn.discordapp.com/attachments/126077331117834240/1219373099821170749/image.png?ex=660b10b1&is=65f89bb1&hm=176fc2cd34ba7a28b0bbfd5f84831ecfc2d98fbaacbe3f08c4d86c5046f920b3&

https://cdn.discordapp.com/attachments/126077331117834240/1219373212333379795/image.png?ex=660b10cc&is=65f89bcc&hm=c8cfc7da432b73e2cc05c3e8de117bcb8c0e1043d03b518e045729fe6f530024&

@Sourceshard
Copy link
Author

Sourceshard commented Mar 18, 2024

Running BetterShotgun with a very stripped down modpack (only the basics) shows Shell properly in the store.

@Sourceshard
Copy link
Author

Sourceshard commented Mar 18, 2024

Removing BetterShotgun stops the Shotgun and Shells/Ammo from appearing in the store. So it appears that it is not a conflict of a mod adding an identical value/item to the store. But with the naming and identification being influenced by some other source.

@Sourceshard
Copy link
Author

Possible conflict with reserved ammo slot and your renaming.

Reserved WeaponSlot/AmmoSlot
image

image

@Sourceshard
Copy link
Author

Also possible problem with the implementation of the shotgun and how it is read by other mods and the Lethal Level Loader store menu. Possible problem with Terminal Formatter.
https://thunderstore.io/c/lethal-company/p/mrov/TerminalFormatter/

image

https://github.com/Hypick122/BetterShotgun/blob/d9be920be0368b71320ba8afd185102201f2a6b8/BetterShotgun/Plugin.cs

@Sourceshard
Copy link
Author

A link to the discord conversation trying to figure things out.

https://discord.com/channels/1168655651455639582/1177039162428366848/1219374260196348047

@Hypick122
Copy link
Owner

Hypick122 commented Mar 19, 2024

A link to the discord conversation trying to figure things out.

https://discord.com/channels/1168655651455639582/1177039162428366848/1219374260196348047

It looks like I'm not on this server.
image

Possible conflict with reserved ammo slot and your renaming.

Removed the check for ReservedWeaponSlot and replaced the default name with Shells. (98efc50)

@Sourceshard
Copy link
Author

Shells still display as Ammo in store.

Also have a new bug that I will open up a ticket for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants