Removed usage of MD5 from calc_label_from_name (#2062)

Removed usage of MD5 from calc_label_from_name
HypothesisWorks · Jul 28, 2019 · 549fe13 · 549fe13
2 parents 0cc3c1d + d38a4c8
commit 549fe13
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
@@ -185,6 +185,7 @@ their individual contributions.
 
 * `Adam Johnson <https://github.com/adamchainz>`_
 * `Adam Sven Johnson <https://www.github.com/pkqk>`_
+* `Alex Gaynor <https://github.com/alex>`_
 * `Alex Stapleton <https://www.github.com/public>`_
 * `Alex Willmer <https://github.com/moreati>`_ (alex@moreati.org.uk)
 * `Ben Peterson <https://github.com/killthrush>`_ (killthrush@hotmail.com)

diff --git a/hypothesis-python/RELEASE.rst b/hypothesis-python/RELEASE.rst
@@ -0,0 +1,6 @@
+RELEASE_TYPE: patch
+
+This patch changes an internal use of MD5 to SHA hashes, to better support
+users subject to FIPS-140.  There is no user-visible or API change.
+
+Thanks to Alex Gaynor for this patch.
diff --git a/hypothesis-python/docs/changes.rst b/hypothesis-python/docs/changes.rst
@@ -1697,7 +1697,7 @@ cause errors on Python 3 due to internal rounding.
 -------------------
 
 Hypothesis now seeds and resets the global state of
-:class:`np.random <numpy:numpy.random.RandomState>` for each
+:mod:`np.random <numpy:numpy.random>` for each
 test case, to ensure that tests are reproducible.
 
 This matches and complements the existing handling of the

diff --git a/hypothesis-python/src/hypothesis/internal/conjecture/utils.py b/hypothesis-python/src/hypothesis/internal/conjecture/utils.py
@@ -39,7 +39,7 @@
 
 
 def calc_label_from_name(name):
-    hashed = hashlib.md5(str_to_bytes(name)).digest()
+    hashed = hashlib.sha384(str_to_bytes(name)).digest()
     return int_from_bytes(hashed[:8])