Apply suggestions from code review

Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>

hypothesis-python/RELEASE.rst

@@ -1,4 +1,4 @@
-RELEASE_TYPE: patch
+RELEASE_TYPE: minor
 
-This patch adds a codemod to convert deprecated Healthcheck.all() 
-into list(Healthcheck) as a part of issue #3596.
+This release deprecates ``Healthcheck.all()``, and :ref:`adds a codemod <codemods>`
+to automatically replace it with ``list(Healthcheck)`` (:issue:`3596`).

hypothesis-python/src/hypothesis/_settings.py

@@ -465,8 +465,8 @@ def __repr__(self):
     def all(cls) -> List["HealthCheck"]:
         # Skipping of deprecated attributes is handled in HealthCheckMeta.__iter__
         note_deprecation(
-            f"The Healthcheck.all() method is deprecated, instead opting for list(HealthCheck)",
-            since="2023-04-07",
+            f"`Healthcheck.all()` is deprecated; use `list(HealthCheck)` instead.",
+            since="RELEASEDAY",
             has_codemod=True,
         )
         return list(HealthCheck)

hypothesis-python/src/hypothesis/extra/codemods.py

@@ -234,10 +234,7 @@ def leave_Call(self, original_node: cst.Call, updated_node: cst.Call) -> cst.Cal
             updated_node.func,
             m.Attribute(value=m.Name("Healthcheck"), attr=m.Name("all")),
         ):
-            new_node = cst.Call(
-                func=cst.Name("list"), args=[cst.Arg(value=cst.Name("Healthcheck"))]
+            return updated_node.with_changes(
+                func=cst.Name("list"),
+                args=[cst.Arg(value=cst.Name("Healthcheck"))],
             )
-            updated_node = updated_node.with_changes(
-                func=new_node.func, args=new_node.args
-            )
-        return updated_node