Improved clarity in ellipsis indices test (NumPy and Array API)

Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
HypothesisWorks · Sep 10, 2021 · fba0fb2 · fba0fb2
1 parent b6c2e42
commit fba0fb2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/hypothesis-python/tests/array_api/test_indices.py b/hypothesis-python/tests/array_api/test_indices.py
@@ -66,8 +66,9 @@ def test_indices_can_generate_long_ellipsis():
     )
 )
 def test_indices_replaces_whole_axis_slices_with_ellipsis(idx):
-    # When a shape's dimension sizes are 0, ... in indices replaces all slice
-    # and integer entries in the index.
+    # `slice(None)` (aka `:`) is the only valid index for an axis of size
+    # zero, so if all dimensions are 0 then a `...` will replace all the
+    # slices because we generate `...` for entire contiguous runs of `:`
     assert slice(None) not in idx
 
 

diff --git a/hypothesis-python/tests/numpy/test_gen_data.py b/hypothesis-python/tests/numpy/test_gen_data.py
@@ -1106,8 +1106,9 @@ def test_basic_indices_can_generate_long_ellipsis():
     )
 )
 def test_basic_indices_replaces_whole_axis_slices_with_ellipsis(idx):
-    # When a shape's dimension sizes are 0, ... in indices replaces all slice
-    # and integer entries in the index.
+    # `slice(None)` (aka `:`) is the only valid index for an axis of size
+    # zero, so if all dimensions are 0 then a `...` will replace all the
+    # slices because we generate `...` for entire contiguous runs of `:`
     assert slice(None) not in idx