Typos fixed #2893
Merged
Typos fixed #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
added
docs
|
LGTM! I also tried to automate this as part of our |
|
@Zac-HD thanks a lot for your help! I will finish it next week 👍 |
|
It took me more time than a week 😅 |
Zac-HD
approved these changes
Mar 27, 2021
| "--check-hidden", | ||
| "--check-filenames", | ||
| "--ignore-words=./tooling/ignore-list.txt", | ||
| "--skip=__pycache__,_build,.mypy_cache,.venv,.git,tlds-alpha-by-domain.txt", |
There was a problem hiding this comment.
Suggested change
| "--skip=__pycache__,_build,.mypy_cache,.venv,.git,tlds-alpha-by-domain.txt", |
These are already handled by the logic which chooses while files to format, or the comprehension in lint().
There was a problem hiding this comment.
Actually, no. We still need this line for some reason.
I was also surprised.
Proof (calling codespell without --skip) by TASK=codespell ./build.sh:
There was a problem hiding this comment.
Weird! If that's how it works though, let's leave it as-is 🙂
|
Thanks a lot, @Zac-HD! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using https://github.com/codespell-project/codespell to find typos, it works pretty well!
We can even automate this check later on:
whitelist.txtof words that are ignored, likestratFull example: https://github.com/dry-python/returns/blob/master/setup.cfg#L191-L194