Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when passing *strategies* as elements to sampled_from (rather than to one_of)? #3819

Closed
vreuter opened this issue Dec 20, 2023 · 0 comments · Fixed by #3820
Closed

Warn when passing *strategies* as elements to sampled_from (rather than to one_of)? #3819

vreuter opened this issue Dec 20, 2023 · 0 comments · Fixed by #3820
Labels
legibility make errors helpful and Hypothesis grokable

Comments

@vreuter
Copy link
Contributor

vreuter commented Dec 20, 2023

I was just making an error passing values of strategy type to the elements parameter of sampled_from when what I should've been using was one_of. This gave me some initially unexpected results, as I was dealing in the body of my test case with values of strategy type than rather than the values I expected to be generated from them.

What do you think about a warning message or an error when passing strategies as elements to sampled_from? Naively, it seems like this would more often be in error (mis/incomplete understanding of the API, confusing sampled_from and one_of) than in intention.

Regardless, thanks for a great library!
@vreuter vreuter changed the title Warn when passing strategies as elements to sampled_from (rather than to one_of)? Warn when passing strategies as elements to sampled_from (rather than to one_of)? Dec 20, 2023
@vreuter vreuter changed the title Warn when passing strategies as elements to sampled_from (rather than to one_of)? Warn when passing _strategies_ as elements to sampled_from (rather than to one_of)? Dec 20, 2023
@vreuter vreuter changed the title Warn when passing _strategies_ as elements to sampled_from (rather than to one_of)? Warn when passing *strategies* as elements to sampled_from (rather than to one_of)? Dec 20, 2023
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 22, 2023
@vreuter
add warning all elements to sampled_from are strategies, suggestive o…
0504153 
…f one_of; close HypothesisWorks#3819
@vreuter vreuter mentioned this issue Dec 22, 2023
Merged
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 22, 2023
@vreuter
add warning all elements to sampled_from are strategies, suggestive o…
60754dc 
…f one_of; close HypothesisWorks#3819
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 22, 2023
@vreuter
add warning all elements to sampled_from are strategies, suggestive o…
f647beb 
…f one_of; close HypothesisWorks#3819
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 22, 2023
@vreuter
add warning all elements to sampled_from are strategies, suggestive o…
4880b11 
…f one_of; close HypothesisWorks#3819
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 22, 2023
@vreuter
add warning all elements to sampled_from are strategies, suggestive o…
370f6ce 
…f one_of; close HypothesisWorks#3819
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 22, 2023
@vreuter
add warning all elements to sampled_from are strategies, suggestive o…
b19295d 
…f one_of; close HypothesisWorks#3819
@Zac-HD Zac-HD added the legibility make errors helpful and Hypothesis grokable label Dec 22, 2023
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 26, 2023
@vreuter
narrow the severity and cases for alternate API use suggestion; close H…
81232a2 
…ypothesisWorks#3819

Revised per suggestion here: HypothesisWorks#3820 (comment)
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 26, 2023
@vreuter
narrow the severity and cases for alternate API use suggestion; close H…
a8a5635 
…ypothesisWorks#3819

Revised per suggestion here: HypothesisWorks#3820 (comment)
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 26, 2023
@vreuter
narrow the severity and cases for alternate API use suggestion; close H…
7706606 
…ypothesisWorks#3819

Revised per suggestion here: HypothesisWorks#3820 (comment)
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 29, 2023
@vreuter
add direct draw tests for HypothesisWorks#3819; condense and narrow a…
bed2cf5 
…ssertion logic
vreuter added a commit to vreuter/hypothesis that referenced this issue Dec 31, 2023
@vreuter
more informative note for HypothesisWorks#3819
4948d08
vreuter added a commit to vreuter/hypothesis that referenced this issue Jan 3, 2024
@vreuter
limit the number of elements shown for API use suggestion; Hypothesis…
4543005 
…Works#3819
vreuter added a commit to vreuter/hypothesis that referenced this issue Jan 3, 2024
@vreuter
limit the number of elements shown for API use suggestion; Hypothesis…
699850f 
…Works#3819
Zac-HD pushed a commit to vreuter/hypothesis that referenced this issue Jan 8, 2024
@vreuter @Zac-HD
add warning all elements to sampled_from are strategies, suggestive o…
a004dbb 
…f one_of; close HypothesisWorks#3819
Zac-HD pushed a commit to vreuter/hypothesis that referenced this issue Jan 8, 2024
@vreuter @Zac-HD
narrow the severity and cases for alternate API use suggestion; close H…
e50d6a4 
…ypothesisWorks#3819

Revised per suggestion here: HypothesisWorks#3820 (comment)
Zac-HD pushed a commit to vreuter/hypothesis that referenced this issue Jan 8, 2024
@vreuter @Zac-HD
add direct draw tests for HypothesisWorks#3819; condense and narrow a…
4fdeade 
…ssertion logic
Zac-HD pushed a commit to vreuter/hypothesis that referenced this issue Jan 8, 2024
@vreuter @Zac-HD
more informative note for HypothesisWorks#3819
dd36487
Zac-HD pushed a commit to vreuter/hypothesis that referenced this issue Jan 8, 2024
@vreuter @Zac-HD
limit the number of elements shown for API use suggestion; Hypothesis…
2c37fb7 
…Works#3819
@vreuter vreuter mentioned this issue Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
legibility make errors helpful and Hypothesis grokable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note to TypeError when each element to sampled_from is a strategy vreuter/hypothesis
2 participants
@vreuter @Zac-HD